SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #141] Fix disk setup and documentation for Turnkey VMs #2410

New Issue
Closed
opened 2025-11-20 05:29:42 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:29:42 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/141

State: closed
Merged: Yes

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Turnkey VM scripts have only had a bootdisk with ISO image, so people had to figure out themselves that another disk must be added to partition and install OS on. This issue caused Tteck to remove docs until more testing had been done: https://github.com/tteck/Proxmox/discussions/2351#discussioncomment-8144087

This PR

  • Fixes Turnkey VM scripts by adding another disk for OS installation
  • Adds back documentation for Turnkey Nextcloud VM
  • Fixes documentation for Turnkey ownCloud VM
  • Fixes documentation for Jellyfin (crashes in production atm)
  • Changes unique script identifier in frontend from name to slug, because name is not unique (we have both Nextcloud VM and LXC). This will be a breaking change for id param in URL (if anyone have a script bookmarked), but it's better to do this change as early as possible. slug should always be unique since it is the same as script filename.

I am also planning on creating a Turnkey VM Install Guide in Github discussions to reference in documentation, since those VMs require a bootdisk installation process.

Fixes https://github.com/community-scripts/ProxmoxVE/issues/93
Fixes https://github.com/tteck/Proxmox/discussions/2351#discussioncomment-8144087

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)
  • Documentation update required (this change requires an update to the documentation)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

hardware
partition-2
docs

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/141 **State:** closed **Merged:** Yes --- > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Turnkey VM scripts have only had a bootdisk with ISO image, so people had to figure out themselves that another disk must be added to partition and install OS on. This issue caused Tteck to remove docs until more testing had been done: https://github.com/tteck/Proxmox/discussions/2351#discussioncomment-8144087 This PR - Fixes Turnkey VM scripts by adding another disk for OS installation - Adds back documentation for Turnkey Nextcloud VM - Fixes documentation for Turnkey ownCloud VM - Fixes documentation for Jellyfin (crashes in production atm) - Changes unique script identifier in frontend from `name` to `slug`, because name is not unique (we have both Nextcloud VM and LXC). This will be a breaking change for id param in URL (if anyone have a script bookmarked), but it's better to do this change as early as possible. `slug` should always be unique since it is the same as script filename. I am also planning on creating a `Turnkey VM Install Guide` in Github discussions to reference in documentation, since those VMs require a bootdisk installation process. Fixes https://github.com/community-scripts/ProxmoxVE/issues/93 Fixes https://github.com/tteck/Proxmox/discussions/2351#discussioncomment-8144087 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) - [x] Documentation update required (this change requires an update to the documentation) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ![hardware](https://github.com/user-attachments/assets/c65fc733-6a0f-4a45-9ba4-e73d6a7107bd) ![partition-2](https://github.com/user-attachments/assets/586264a6-c160-428a-ae1b-c488f83c00b4) ![docs](https://github.com/user-attachments/assets/abc77e14-6f16-4145-8f99-d7f58979277e)
saavagebueno added the pull-request label 2025-11-20 05:29:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?