SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-28 02:52:23 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #320] [CLOSED] Give option to proceed with installation on unsupported PVE versions #2487

New Issue
Closed
opened 2025-11-20 05:30:17 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/320
Author: @remz1337
Created: 11/17/2024
Status: ❌ Closed

Base: main ← Head: pve_check

📝 Commits (2)

  • bcd6393 Give option to proceed with installation on unsupported PVE versions
  • e043dfe Small typo

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 misc/build.func (+7 -2)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Small update to the pve_check function to give the option to users running older PVE version to still proceed with the scripts. We should keep the "officially supported" version to the latest major PVE, but I myself took a long time to migrate from PVE 7 to 8, and all scripts still worked fine.

Still, this comes with a big disclaimer that older version are unsupported, thus if they face any issue, they should upgrade and test again before opening an issue.

Let me know what you think. Not much of an issue on my end anymore since I upgraded, but I figured some may be in that situation.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/320 **Author:** [@remz1337](https://github.com/remz1337) **Created:** 11/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pve_check` --- ### 📝 Commits (2) - [`bcd6393`](https://github.com/community-scripts/ProxmoxVE/commit/bcd6393fcfc419a81c2d5249f722151d21d9e671) Give option to proceed with installation on unsupported PVE versions - [`e043dfe`](https://github.com/community-scripts/ProxmoxVE/commit/e043dfe6cd1d494bc06c53c795908a75d0706745) Small typo ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+7 -2) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Small update to the `pve_check` function to give the option to users running older PVE version to still proceed with the scripts. We should keep the "officially supported" version to the latest major PVE, but I myself took a long time to migrate from PVE 7 to 8, and all scripts still worked fine. Still, this comes with a big disclaimer that older version are unsupported, thus if they face any issue, they should upgrade and test again before opening an issue. Let me know what you think. Not much of an issue on my end anymore since I upgraded, but I figured some may be in that situation. ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [X] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2487
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?