SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #374] Replace dash "-" with "/" in metadata #2508

New Issue
Closed
opened 2025-11-20 05:30:24 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:24 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/374

State: closed
Merged: Yes

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Categories currently use the dash "-" symbol to represent shorthand "and" in category names in the metadata.

This is contra to normal English language usage and informal web usage where "-" is usually used to denote a category, or sub-category.

In informal english language "/" usually means logical "or" (a set encompassing all of A, all of B including all of A and B).

I also think it looks better.

Matter/Zigbee/Zwave was renamed to continue to make sense.

I have some further taxonomical changes I want to suggest but this needs to be first to avoid conflicting PR.

Screenshot:

Screenshot 2024-11-20 at 11 53 20 AM

You can have a look at a demo of it here (Edit: I use my main branch for testing so might not always be the demo):

https://newzealandpaul.github.io/ProxmoxVE/scripts

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

I also tried "&" symbol and it didn't look as nice.

Screenshot 2024-11-20 at 11 39 14 AM
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/374 **State:** closed **Merged:** Yes --- > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Categories currently use the dash "-" symbol to represent shorthand "and" in category names in the metadata. This is contra to normal English language usage and informal web usage where "-" is usually used to denote a category, or sub-category. In informal english language "/" usually means logical "or" (a set encompassing all of A, all of B including all of A and B). I also think it looks better. Matter/Zigbee/Zwave was renamed to continue to make sense. I have some further taxonomical changes I want to suggest but this needs to be first to avoid conflicting PR. Screenshot: <img width="311" alt="Screenshot 2024-11-20 at 11 53 20 AM" src="https://github.com/user-attachments/assets/7b79d9de-9871-48e4-bd67-ede2e9b19594"> You can have a look at a demo of it here (Edit: I use my main branch for testing so might not always be the demo): https://newzealandpaul.github.io/ProxmoxVE/scripts ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) I also tried "&" symbol and it didn't look as nice. <img width="359" alt="Screenshot 2024-11-20 at 11 39 14 AM" src="https://github.com/user-attachments/assets/0324c387-c5e8-4c01-8b99-5ea48b0406db">
saavagebueno added the pull-request label 2025-11-20 05:30:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2508
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?