[PR #378] [MERGED] Proxmox VE Cron LXC Updater: Add tteck's notes. #2510

Closed
opened 2025-11-20 05:30:24 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/378
Author: @newzealandpaul
Created: 11/19/2024
Status: Merged
Merged: 11/20/2024
Merged by: @MickLesk

Base: mainHead: nzp-cron


📝 Commits (5)

  • 153807d Added text from tteck's original
  • 9c1f31b warning as info not yet supported
  • 24c273f fix spacing
  • 99e38c2 changed working and line spacing
  • ca5e2bf Update json/cron-update-lxcs.json

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 json/cron-update-lxcs.json (+6 -1)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Adds the note from https://tteck.github.io/Proxmox/ to avoid confusion with users.

Added as a warning as info does not yet work.

Fixes #375

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/378 **Author:** [@newzealandpaul](https://github.com/newzealandpaul) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `nzp-cron` --- ### 📝 Commits (5) - [`153807d`](https://github.com/community-scripts/ProxmoxVE/commit/153807d50a3e58ee50ccfb822e98d607433db34b) Added text from tteck's original - [`9c1f31b`](https://github.com/community-scripts/ProxmoxVE/commit/9c1f31be3496169662201d8fb5de05374d63bd45) warning as info not yet supported - [`24c273f`](https://github.com/community-scripts/ProxmoxVE/commit/24c273f6da5d7995c9c40424da8e2a16d9956c24) fix spacing - [`99e38c2`](https://github.com/community-scripts/ProxmoxVE/commit/99e38c2cfd495e517e9cc8153d472f25830fb27a) changed working and line spacing - [`ca5e2bf`](https://github.com/community-scripts/ProxmoxVE/commit/ca5e2bfa124a7d067c3b75043fd32a5acb8582ed) Update json/cron-update-lxcs.json ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `json/cron-update-lxcs.json` (+6 -1) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Adds the note from https://tteck.github.io/Proxmox/ to avoid confusion with users. Added as a warning as info does not yet work. Fixes #375 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2510