SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #405] [MERGED] Website: Add discord link to navbar #2516

New Issue
Closed
opened 2025-11-20 05:30:27 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/405
Author: @BramSuurdje
Created: 11/20/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @BramSuurdje

Base: main ← Head: main

📝 Commits (6)

  • 4dc3357 Refactor Buttons component to use a ButtonLink for cleaner code, simplifying the source URL generation and layout
  • ef648f1 Refactor DefaultPassword component to simplify credential handling and enhance code readability with map function
  • 3826006 Refactor DefaultSettings component to improve resource display logic and enhance readability using a new ResourceDisplay subcomponent
  • d0d0ba4 Add Discord link and icon to site configuration
  • 8cd6207 Update siteConfig to hide icons on small screens, improving responsive design for navbar links
  • df9e39b Merge branch 'community-scripts:main' into main

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 frontend/src/config/siteConfig.tsx (+9 -3)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This pull request to frontend/src/config/siteConfig.tsx includes changes to add a Discord link to the navbar and improve the responsiveness of some icons. The most important changes include adding the Discord icon import, updating the navbarLinks to include a Discord link, and modifying the visibility of some icons for small screens.

Additions and updates to navbar links:

  • Added a new Discord link with the appropriate icon and text to the navbarLinks array.

Responsiveness improvements:

  • Modified the Change Log and Discussions icons to be hidden on small screens by adding the hidden sm:block classes.

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.
image

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/405 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 11/20/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@BramSuurdje](https://github.com/BramSuurdje) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`4dc3357`](https://github.com/community-scripts/ProxmoxVE/commit/4dc33573e4b793b9484c761776b9d03332253602) Refactor Buttons component to use a ButtonLink for cleaner code, simplifying the source URL generation and layout - [`ef648f1`](https://github.com/community-scripts/ProxmoxVE/commit/ef648f17595f7f2b1ccb02b9769528b82f257040) Refactor DefaultPassword component to simplify credential handling and enhance code readability with map function - [`3826006`](https://github.com/community-scripts/ProxmoxVE/commit/382600689c0e36fdd715bc8bf7c59fff089ca041) Refactor DefaultSettings component to improve resource display logic and enhance readability using a new ResourceDisplay subcomponent - [`d0d0ba4`](https://github.com/community-scripts/ProxmoxVE/commit/d0d0ba47a9f9616a0b25ed9807710b445b0a6e95) Add Discord link and icon to site configuration - [`8cd6207`](https://github.com/community-scripts/ProxmoxVE/commit/8cd6207078a28aafe7191c6cebb6d499a8d7b494) Update siteConfig to hide icons on small screens, improving responsive design for navbar links - [`df9e39b`](https://github.com/community-scripts/ProxmoxVE/commit/df9e39bf5bb3570b66d1c91eb3c1ec296595e396) Merge branch 'community-scripts:main' into main ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/config/siteConfig.tsx` (+9 -3) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description This pull request to `frontend/src/config/siteConfig.tsx` includes changes to add a Discord link to the navbar and improve the responsiveness of some icons. The most important changes include adding the Discord icon import, updating the `navbarLinks` to include a Discord link, and modifying the visibility of some icons for small screens. Additions and updates to navbar links: * Added a new Discord link with the appropriate icon and text to the `navbarLinks` array. Responsiveness improvements: * Modified the `Change Log` and `Discussions` icons to be hidden on small screens by adding the `hidden sm:block` classes. Fixes # (issue) ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. <img width="770" alt="image" src="https://github.com/user-attachments/assets/985ece5a-66b2-4f54-9296-d6ecdcf60485"> ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?