SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #428] [CLOSED] generate_app_name in build.func #2526

New Issue
Open
opened 2025-11-20 05:30:29 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/428
Author: @MickLesk
Created: 11/22/2024
Status: ❌ Closed

Base: main ← Head: build.func-generate_app_name

📝 Commits (4)

📊 Changes

1 file changed (+16 additions, -0 deletions)

View changed files

📝 misc/build.func (+16 -0)

📄 Description

Description

Adding an ascii generation. Not so much code is needed anymore and cleans up the CT.sh.

In addition, the PR of new scripts no longer causes the problem that the wrong ASCII is used.

As Example:
https://github.com/MickLesk/Proxmox_DEV/blob/main/ct/nextpvr.sh

You can test it with:

 bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/nextpvr.sh)"

Only this needed:

function header_info {
clear
generate_app_name "AppName"
}
header_info

Breaking Change, because i use the tool: figlet
Its a very small tool.

=> Create Documentation:
Users can created the tool self with "apt-get install figlet" or my script do it (without output)

Log

Need to get 137 kB of archives.
After this operation, 757 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian bookworm/main amd64 figlet amd64 2.2.5-3+b1 [137 kB]
Fetched 137 kB in 0s (665 kB/s)

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/428 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 11/22/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `build.func-generate_app_name` --- ### 📝 Commits (4) - [`4e78ca1`](https://github.com/community-scripts/ProxmoxVE/commit/4e78ca13816cb6ec34a2dcc80079d5b31393e671) generate_app_name in build.func - [`ee91367`](https://github.com/community-scripts/ProxmoxVE/commit/ee913677509c7658ce3e8200686a3b150f71d054) update comments in english - [`ec7e341`](https://github.com/community-scripts/ProxmoxVE/commit/ec7e3411e7118a180a7f89ee4c63f0fe51a6c316) remove cat comment - [`3cf01d3`](https://github.com/community-scripts/ProxmoxVE/commit/3cf01d3ea3e2e7d5af25401e20d050d623992ab8) Update misc/build.func ### 📊 Changes **1 file changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+16 -0) </details> ### 📄 Description ## Description Adding an ascii generation. Not so much code is needed anymore and cleans up the CT.sh. In addition, the PR of new scripts no longer causes the problem that the wrong ASCII is used. As Example: https://github.com/MickLesk/Proxmox_DEV/blob/main/ct/nextpvr.sh You can test it with: ```bash bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/nextpvr.sh)" ``` Only this needed: ```bash function header_info { clear generate_app_name "AppName" } header_info ``` Breaking Change, because i use the tool: figlet Its a very small tool. => Create Documentation: Users can created the tool self with "apt-get install figlet" or my script do it (without output) Log ```sh Need to get 137 kB of archives. After this operation, 757 kB of additional disk space will be used. Get:1 http://deb.debian.org/debian bookworm/main amd64 figlet amd64 2.2.5-3+b1 [137 kB] Fetched 137 kB in 0s (665 kB/s) ``` Fixes # (issue) ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ![image](https://github.com/user-attachments/assets/fed46b8e-b1e3-4173-a6ff-4ea140e91c31) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?