Font error when running scripts if TOilet is installed and not figlet #253

@oOStroudyOo commented on GitHub (Dec 29, 2024):

I was unable to replicate the issue, even with uninstalling figlet and allowing the helper-script to reinstall it:

I am running a slightly newer version of pve-manager/8.3.2/3e76eec21c4a14a7 but there isn't anything in the Proxmox change log relating to Figlet.

@oOStroudyOo commented on GitHub (Dec 29, 2024): I was unable to replicate the issue, even with uninstalling figlet and allowing the helper-script to reinstall it: ![image](https://github.com/user-attachments/assets/a2b3d37f-2af6-476f-9973-68bd551eade4) I am running a slightly newer version of pve-manager/8.3.2/3e76eec21c4a14a7 but there isn't anything in the Proxmox change log relating to Figlet.

saavagebueno commented

@bigrichwood commented on GitHub (Dec 29, 2024):

Having done a bit more digging, my Proxmox nodes have an old version of TOilet which includes a figlet binary. This version does not support the font slant, and I think was installed as a dependecy of neofetch.

rich@organa:~$ figlet -v
TOIlet Copyright 2006 Sam Hocevar
Internet: sam@hocevar.net Version: 0.3, date:

If I install with an apt install figlet, you get a version which does support the appropriate fonts.

rich@organa:~$ figlet -v
FIGlet Copyright (C) 1991-2012 Glenn Chappell, Ian Chai, John Cowan, Christiaan Keet and Claudio Matsuoka
Internet: info@figlet.org Version: 2.2.5, date: 31 May 2012

So it looks like simply checking for the existance of figlet in the script isn't enough, it needs to check if it's a suitable version.

@bigrichwood commented on GitHub (Dec 29, 2024): Having done a bit more digging, my Proxmox nodes have an old version of TOilet which includes a figlet binary. This version does not support the font slant, and I think was installed as a dependecy of neofetch. rich@organa:~$ figlet -v TOIlet Copyright 2006 Sam Hocevar Internet: <sam@hocevar.net> Version: 0.3, date: If I install with an apt install figlet, you get a version which does support the appropriate fonts. rich@organa:~$ figlet -v FIGlet Copyright (C) 1991-2012 Glenn Chappell, Ian Chai, John Cowan, Christiaan Keet and Claudio Matsuoka Internet: <info@figlet.org> Version: 2.2.5, date: 31 May 2012 So it looks like simply checking for the existance of figlet in the script isn't enough, it needs to check if it's a suitable version.

saavagebueno commented

@MickLesk commented on GitHub (Dec 29, 2024):

Can you Update your issue description & title with your latest Message? Then i can check it in a few days

@MickLesk commented on GitHub (Dec 29, 2024): Can you Update your issue description & title with your latest Message? Then i can check it in a few days

saavagebueno commented

@bigrichwood commented on GitHub (Dec 29, 2024):

Can you Update your issue description & title with your latest Message? Then i can check it in a few days

Hopefully my updates make sense. https://github.com/community-scripts/ProxmoxVE/issues/1083 is probably the same issue.

@bigrichwood commented on GitHub (Dec 29, 2024): > Can you Update your issue description & title with your latest Message? Then i can check it in a few days Hopefully my updates make sense. https://github.com/community-scripts/ProxmoxVE/issues/1083 is probably the same issue.

saavagebueno commented

@onethree7 commented on GitHub (Dec 30, 2024):

Having done a bit more digging, my Proxmox nodes have an old version of TOilet which includes a figlet binary. This version does not support the font slant, and I think was installed as a dependecy of neofetch.

rich@organa:~$ figlet -v TOIlet Copyright 2006 Sam Hocevar Internet: sam@hocevar.net Version: 0.3, date:

If I install with an apt install figlet, you get a version which does support the appropriate fonts.

rich@organa:~$ figlet -v FIGlet Copyright (C) 1991-2012 Glenn Chappell, Ian Chai, John Cowan, Christiaan Keet and Claudio Matsuoka Internet: info@figlet.org Version: 2.2.5, date: 31 May 2012

So it looks like simply checking for the existance of figlet in the script isn't enough, it needs to check if it's a suitable version.

you are 100% correct and its reproducable as such. Not creating another issue for #jellyfin . This is everywhere, neofetch is basic to all my LXC.

EDIT: Via SSH its erroring before whiptail can load the promptwindow, via Console it allows to do a Whiptail decision, and then error out.

And i tested the old tteck script which still worked in comparison.

@onethree7 commented on GitHub (Dec 30, 2024): > Having done a bit more digging, my Proxmox nodes have an old version of TOilet which includes a figlet binary. This version does not support the font slant, and I think was installed as a dependecy of neofetch. > > rich@organa:~$ figlet -v TOIlet Copyright 2006 Sam Hocevar Internet: [sam@hocevar.net](mailto:sam@hocevar.net) Version: 0.3, date: > > If I install with an apt install figlet, you get a version which does support the appropriate fonts. > > rich@organa:~$ figlet -v FIGlet Copyright (C) 1991-2012 Glenn Chappell, Ian Chai, John Cowan, Christiaan Keet and Claudio Matsuoka Internet: [info@figlet.org](mailto:info@figlet.org) Version: 2.2.5, date: 31 May 2012 > > So it looks like simply checking for the existance of figlet in the script isn't enough, it needs to check if it's a suitable version. you are 100% correct and its reproducable as such. Not creating another issue for #jellyfin . This is everywhere, neofetch is basic to all my LXC. EDIT: Via SSH its erroring before whiptail can load the promptwindow, via Console it allows to do a Whiptail decision, and then error out. And i tested the old tteck script which still worked in comparison.

saavagebueno commented

@vsisl commented on GitHub (Dec 30, 2024):

I seemingly have the same problem when installing Adguard LXC.

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/adguard.sh)"

error: could not load font slant

[ERROR] in line 227: exit code 0: while executing command ascii_art=$(figlet -f slant -w "$term_width" "$APP")

@vsisl commented on GitHub (Dec 30, 2024): I seemingly have the same problem when installing [Adguard LXC](https://community-scripts.github.io/ProxmoxVE/scripts?id=adguard). ```bash bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/adguard.sh)" error: could not load font slant [ERROR] in line 227: exit code 0: while executing command ascii_art=$(figlet -f slant -w "$term_width" "$APP") ```

saavagebueno commented

@MickLesk commented on GitHub (Dec 30, 2024):

I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason?

@MickLesk commented on GitHub (Dec 30, 2024): I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason?

saavagebueno commented

@bigrichwood commented on GitHub (Dec 30, 2024):

I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason?

It’s the version currently available in Debian stable packages (https://packages.debian.org/stable/text/toilet), and installed as a dependency of a dependency of another package I use, neofetch.

@bigrichwood commented on GitHub (Dec 30, 2024): > I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason? It’s the version currently available in Debian stable packages (https://packages.debian.org/stable/text/toilet), and installed as a dependency of a dependency of another package I use, neofetch.

saavagebueno commented

@MickLesk commented on GitHub (Dec 30, 2024):

Does neofetch running with the .tar.xz in our misc Project folder? Thats the latest figlet

@MickLesk commented on GitHub (Dec 30, 2024): Does neofetch running with the .tar.xz in our misc Project folder? Thats the latest figlet

saavagebueno commented

@vsisl commented on GitHub (Dec 31, 2024):

I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason?

I'm running Proxmox VE 8.3.2

I also have neofetch installed. So maybe it's indeed caused by neofetch? How could I update or install those fonts?

@vsisl commented on GitHub (Dec 31, 2024): > I wonder why you have Toilet or figlet in such ancient versions on the systems? What is the reason? I'm running Proxmox VE 8.3.2 I also have neofetch installed. So maybe it's indeed caused by neofetch? How could I update or install those fonts?

saavagebueno commented

@onethree7 commented on GitHub (Dec 31, 2024):

problem:

root@jellyfin Dec 31 13:43 ~ > figlet -f slant "Tteck forever"
error: could not load font slant

wo:
sudo wget -qO /usr/share/figlet/slant.flf http://www.figlet.org/fonts/slant.flf
works:

root@jellyfin Dec 31 13:42 ~ > figlet -f slant "Tteck forever"
  ________            __      ____                              
 /_  __/ /____  _____/ /__   / __/___  ________ _   _____  _____
  / / / __/ _ \/ ___/ //_/  / /_/ __ \/ ___/ _ \ | / / _ \/ ___/
 / / / /_/  __/ /__/ ,<    / __/ /_/ / /  /  __/ |/ /  __/ /    
/_/  \__/\___/\___/_/|_|  /_/  \____/_/   \___/|___/\___/_/

the fonts are expected in "/usr/share/figlet/"

Can add a check in the build.func header function (although i really would prefer NOT using any fonts , graphics, pictures and icons at all). I (personally!) dont need fancy texts. All i need is a CLI and text in and out. The fancier, the more it breaks.

The header function is already a lot of lines about figlet its getting bigger by fixing the relocating font topic, or it gets bigger by extra lines added to check if figlet -f slant goes 0 or 1 and thus downloading the files. So much lines just for a redundant "ascii"

@onethree7 commented on GitHub (Dec 31, 2024): problem: ``` root@jellyfin Dec 31 13:43 ~ > figlet -f slant "Tteck forever" error: could not load font slant ``` wo: `sudo wget -qO /usr/share/figlet/slant.flf http://www.figlet.org/fonts/slant.flf ` works: ``` root@jellyfin Dec 31 13:42 ~ > figlet -f slant "Tteck forever" ________ __ ____ /_ __/ /____ _____/ /__ / __/___ ________ _ _____ _____ / / / __/ _ \/ ___/ //_/ / /_/ __ \/ ___/ _ \ | / / _ \/ ___/ / / / /_/ __/ /__/ ,< / __/ /_/ / / / __/ |/ / __/ / /_/ \__/\___/\___/_/|_| /_/ \____/_/ \___/|___/\___/_/ ``` the fonts are expected in "**/usr/share/figlet/**" Can add a check in the build.func header function (although i really would prefer NOT using any fonts , graphics, pictures and icons at all). I (personally!) dont need fancy texts. All i need is a CLI and text in and out. The fancier, the more it breaks. The header function is already a lot of lines about figlet its getting bigger by fixing the relocating font topic, or it gets bigger by extra lines added to check if figlet -f slant goes 0 or 1 and thus downloading the files. So much lines just for a redundant "ascii"

saavagebueno commented

@MickLesk commented on GitHub (Dec 31, 2024):

yes, ive time for 30min. I Prepare an Update, after merge, can you check it?

@MickLesk commented on GitHub (Dec 31, 2024): yes, ive time for 30min. I Prepare an Update, after merge, can you check it?

saavagebueno commented

@onethree7 commented on GitHub (Dec 31, 2024):

im available.

@onethree7 commented on GitHub (Dec 31, 2024): im available.

saavagebueno commented

@MickLesk commented on GitHub (Dec 31, 2024):

can you check it? ive tested with an clean proxmox vm, should be work. But i dont use toilet or neofetch

@MickLesk commented on GitHub (Dec 31, 2024): can you check it? ive tested with an clean proxmox vm, should be work. But i dont use toilet or neofetch

saavagebueno commented

@onethree7 commented on GitHub (Dec 31, 2024):

this fixed it for me.

i was using the "update" method inside a LXC
i had the dependency Toilet/Figlet version as shown above by others.
my font was not included or placed correctly,
the updated build.func worked around this.

I think the assumption that "if run as INSTALL on the PVE" is fixed, can only be true as well.

@onethree7 commented on GitHub (Dec 31, 2024): this fixed it for me. - i was using the "update" method inside a LXC - i had the dependency Toilet/Figlet version as shown above by others. - my font was not included or placed correctly, - the updated build.func worked around this. I think the assumption that "if run as INSTALL on the PVE" is fixed, can only be true as well.

saavagebueno commented

@MickLesk commented on GitHub (Dec 31, 2024):

I'll leave the issue open, maybe 1-2 others can still test it. But I think that every current use-case should be handled this way.

So now it's PC rest, have a nice New Year's Eve ;)

@MickLesk commented on GitHub (Dec 31, 2024): I'll leave the issue open, maybe 1-2 others can still test it. But I think that every current use-case should be handled this way. So now it's PC rest, have a nice New Year's Eve ;)

saavagebueno commented

@onethree7 commented on GitHub (Dec 31, 2024):

Happy new year , frohes neues :)

@onethree7 commented on GitHub (Dec 31, 2024): Happy new year , frohes neues :)

saavagebueno commented

@vsisl commented on GitHub (Jan 2, 2025):

For what it's worth, I fixed this bug by simply

apt install figlet

@vsisl commented on GitHub (Jan 2, 2025): For what it's worth, I fixed this bug by simply ```bash apt install figlet ```

saavagebueno commented