SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-28 02:52:23 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #455] Fix Actual Budget install missing build tools #2540

New Issue
Open
opened 2025-11-20 05:30:33 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:33 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/455

State: closed
Merged: Yes

Description

The Actual Budget install fails at the yarn install step. Actual Budget depends on better-sqlite3 which uses node-gyp to build the native module. node-gyp requires build tools (namely make and cc) to compile the sqlite module. This PR adds the build-essential package to allow node-gyp to build the sqlite module and successfully complete the Actual Budget installation.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Before adding build tools, running helper script in verbose mode:

Screenshot 2024-11-23 at 10 56 53

The output of the failed build log:
Screenshot 2024-11-23 at 10 46 36

After adding build-essential and running script:
Screenshot 2024-11-23 at 10 44 42

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/455 **State:** closed **Merged:** Yes --- ## Description The Actual Budget install fails at the `yarn install` step. Actual Budget depends on `better-sqlite3` which uses `node-gyp` to build the native module. `node-gyp` requires build tools (namely `make` and `cc`) to compile the sqlite module. This PR adds the `build-essential` package to allow `node-gyp` to build the sqlite module and successfully complete the Actual Budget installation. ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Before adding build tools, running helper script in verbose mode: ![Screenshot 2024-11-23 at 10 56 53](https://github.com/user-attachments/assets/cc61eb01-b522-40a6-9b9e-3cf45ea4847f) The output of the failed build log: ![Screenshot 2024-11-23 at 10 46 36](https://github.com/user-attachments/assets/340edfed-0bea-448a-860a-571532f2a739) After adding build-essential and running script: ![Screenshot 2024-11-23 at 10 44 42](https://github.com/user-attachments/assets/9ba0bca3-7f67-49b5-96c3-f94f6d5b4477)
saavagebueno added the pull-request label 2025-11-20 05:30:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?