SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #472] [CLOSED] New script: Outline LXC #2549

New Issue
Closed
opened 2025-11-20 05:30:36 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/472
Author: @burgerga
Created: 11/23/2024
Status: ❌ Closed

Base: main ← Head: add_outline

📝 Commits (9)

  • 76807c7 Added outline
  • 60f1a6b Temporary override of community-scripts url
  • 7d922d4 Revert "Temporary override of community-scripts url"
  • 4c99c91 Fix service description
  • 302be58 Address reviewer comments
  • 769dc9d Remove db:migrate
  • a57d8ac Use node version directly in url
  • b8a1637 Add empty line before adminer creds
  • 612569b Address further reviewer comments

📊 Changes

3 files changed (+303 additions, -0 deletions)

View changed files

➕ ct/outline.sh (+107 -0)
➕ install/outline-install.sh (+149 -0)
➕ json/outline.json (+47 -0)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Add a community script to install Outline as discussed in https://github.com/community-scripts/ProxmoxVE/discussions/342#discussioncomment-11352475.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

  • You can test with 
    bash -c "$(wget -qLO - https://github.com/burgerga/ProxmoxVE/raw/add_outline/ct/outline.sh)"
    This works because I changed the urls to the community repo in the 2nd commit, this needs to be reverted before merge.
  • Update also works (tested with v0.79 -> v0.81.1, and nothing happens with v0.81.1 -> v0.81.1)
  • Perhaps controversial: this script requires a URL to be set for the app. Since the installation takes kind of long, I moved all user interaction as much to the front as possible. That way you provide some user input at the start, and then you can go do something else, grab a coffee, etc. This will prevent the process being stuck halfway, waiting for some avoidable human input.
  • Please check if the information in the json is enough: this app will not function without 1) reverse proxy that does https, and 2) identity provider that needs to be added to /opt/outline/.env.
  • Script works both on Debian 12 and Ubuntu 24 (didn't test others), should I add both to the json?

Related Pull Requests / Discussions

https://github.com/community-scripts/ProxmoxVE/discussions/342#discussioncomment-11352475

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/472 **Author:** [@burgerga](https://github.com/burgerga) **Created:** 11/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add_outline` --- ### 📝 Commits (9) - [`76807c7`](https://github.com/community-scripts/ProxmoxVE/commit/76807c72e4343da87a9d446671e127520c800825) Added outline - [`60f1a6b`](https://github.com/community-scripts/ProxmoxVE/commit/60f1a6bda2bdf291377114d7e1262d1b693e8c6e) Temporary override of community-scripts url - [`7d922d4`](https://github.com/community-scripts/ProxmoxVE/commit/7d922d4f39811a9e3ed790745a88ef04726711c7) Revert "Temporary override of community-scripts url" - [`4c99c91`](https://github.com/community-scripts/ProxmoxVE/commit/4c99c917bb8ca19990a0dd05bb67ed14bdeb3a0e) Fix service description - [`302be58`](https://github.com/community-scripts/ProxmoxVE/commit/302be583b6368b6ca0b06c02f1435cdfcf73b743) Address reviewer comments - [`769dc9d`](https://github.com/community-scripts/ProxmoxVE/commit/769dc9d0165a2bbd81fce093ab8aa182c3e4715a) Remove db:migrate - [`a57d8ac`](https://github.com/community-scripts/ProxmoxVE/commit/a57d8ac14ec615fa2ad71b0446df599c13ac5986) Use node version directly in url - [`b8a1637`](https://github.com/community-scripts/ProxmoxVE/commit/b8a16376d48d10a731a438b3b58c745acfe36fd9) Add empty line before adminer creds - [`612569b`](https://github.com/community-scripts/ProxmoxVE/commit/612569b955f3f2fb9df88d83451e276c0b01bac0) Address further reviewer comments ### 📊 Changes **3 files changed** (+303 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/outline.sh` (+107 -0) ➕ `install/outline-install.sh` (+149 -0) ➕ `json/outline.json` (+47 -0) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Add a community script to install [Outline](https://www.getoutline.com/) as discussed in https://github.com/community-scripts/ProxmoxVE/discussions/342#discussioncomment-11352475. ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [x] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) - You can test with ```bash bash -c "$(wget -qLO - https://github.com/burgerga/ProxmoxVE/raw/add_outline/ct/outline.sh)" ``` **This works because I changed the urls to the community repo in the 2nd commit, this needs to be reverted before merge.** - Update also works (tested with v0.79 -> v0.81.1, and nothing happens with v0.81.1 -> v0.81.1) - Perhaps controversial: this script requires a URL to be set for the app. Since the installation takes kind of long, I moved all user interaction as much to the front as possible. That way you provide some user input at the start, and then you can go do something else, grab a coffee, etc. This will prevent the process being stuck halfway, waiting for some avoidable human input. - Please check if the information in the json is enough: this app will not function without 1) reverse proxy that does https, and 2) identity provider that needs to be added to `/opt/outline/.env`. - Script works both on Debian 12 and Ubuntu 24 (didn't test others), should I add both to the json? ## Related Pull Requests / Discussions https://github.com/community-scripts/ProxmoxVE/discussions/342#discussioncomment-11352475 If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?