SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #487] [CLOSED] Fix for unreliable IPv4 internet test in alpine-install.func #2557

New Issue
Closed
opened 2025-11-20 05:30:37 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/487
Author: @infinisean
Created: 11/24/2024
Status: ❌ Closed

Base: main ← Head: patch-2

📝 Commits (1)

  • 8f19161 Fix for unreliable IPv4 internet test in alpine-install.func

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 misc/alpine-install.func (+3 -1)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Old test only checked a single IP, which is not ideal if that IP is not up 100% of the time (and it has not been, historically). Added two additional public resolver IPs to the test, e.g. 8.8.8.8 (Google) and 9.9.9.9 (CloudFlare). If any one of the three IPs responds to a ping, the internet verification succeeds. This is much more reliable than using a single IP address. Also moved down the conditional and else for better readability.

Provide a summary of the changes made and/or reference the issue being addressed.
Fixes unreliable IPv4 internet test.

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • [ X ] Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • [ X ] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • [ X ] Testing performed (I have tested my changes, ensuring everything works as expected)
  • [ X ] Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/487 **Author:** [@infinisean](https://github.com/infinisean) **Created:** 11/24/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`8f19161`](https://github.com/community-scripts/ProxmoxVE/commit/8f191615f19fe0ac2bf51e0b175e1a3f4e0fdbbe) Fix for unreliable IPv4 internet test in alpine-install.func ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `misc/alpine-install.func` (+3 -1) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Old test only checked a single IP, which is not ideal if that IP is not up 100% of the time (and it has not been, historically). Added two additional public resolver IPs to the test, e.g. 8.8.8.8 (Google) and 9.9.9.9 (CloudFlare). If any one of the three IPs responds to a ping, the internet verification succeeds. This is much more reliable than using a single IP address. Also moved down the conditional and else for better readability. Provide a summary of the changes made and/or reference the issue being addressed. Fixes unreliable IPv4 internet test. Fixes # (issue) ## Type of change Please check the relevant option(s): - [ X ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [ X ] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [ X ] Testing performed (I have tested my changes, ensuring everything works as expected) - [ X ] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?