SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-28 08:42:37 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #524] [MERGED] Fix Vikunja install script to prevent database deletion upon updating #2575

New Issue
Closed
opened 2025-11-20 05:30:43 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/524
Author: @vhsdream
Created: 11/25/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @MickLesk

Base: main ← Head: vikunja

📝 Commits (10+)

  • 310466f Fix issue with Vikunja update wiping DB and files
  • 379229f use a single sed command
  • 3479bb3 Merge branch 'community-scripts:main' into vikunja
  • 4b8f1ed change build.func to test install script
  • b2f502e Merge branch 'vikunja' of github.com:vhsdream/ProxmoxVE into vikunja
  • 4de09d7 another small change in order to test vikunja fix
  • 46f32c9 another change
  • 3b6ba9a revert URL modification after successful test
  • 89362af Update vikunja-install.sh
  • 446e01f update vikunja-install.sh

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 install/vikunja-install.sh (+3 -1)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This PR addresses an issue in which the Vikunja database (and files folder if created) gets deleted when the user updates Vikunja via the script. The change adds two more substitutions via the sed command to modify the default Vikunja config file; changes the location of the database file and the files folder to /etc/vikunja.

Fixes #502

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation) - There is none, as far as I can tell.

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/524 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `vikunja` --- ### 📝 Commits (10+) - [`310466f`](https://github.com/community-scripts/ProxmoxVE/commit/310466fa9b1690368d55a0e908fb81773c9b4951) Fix issue with Vikunja update wiping DB and files - [`379229f`](https://github.com/community-scripts/ProxmoxVE/commit/379229f89346ab001cbba04e4c311daba91530b0) use a single sed command - [`3479bb3`](https://github.com/community-scripts/ProxmoxVE/commit/3479bb33101e7a9dd8c5f2a26e0d9d0e3ef6c6d5) Merge branch 'community-scripts:main' into vikunja - [`4b8f1ed`](https://github.com/community-scripts/ProxmoxVE/commit/4b8f1ed9674e15ddc87d6f3e0a2402ea663d0d97) change build.func to test install script - [`b2f502e`](https://github.com/community-scripts/ProxmoxVE/commit/b2f502ee2fd12cf990913c4c56bb1851ce0de1c3) Merge branch 'vikunja' of github.com:vhsdream/ProxmoxVE into vikunja - [`4de09d7`](https://github.com/community-scripts/ProxmoxVE/commit/4de09d7c2ba2b074eb51b5dedde95f9292cdac02) another small change in order to test vikunja fix - [`46f32c9`](https://github.com/community-scripts/ProxmoxVE/commit/46f32c907194c6ff67f8ee99c6d811e24bd6c200) another change - [`3b6ba9a`](https://github.com/community-scripts/ProxmoxVE/commit/3b6ba9ad63dde9f69ca9c027b1413f856a96c8fa) revert URL modification after successful test - [`89362af`](https://github.com/community-scripts/ProxmoxVE/commit/89362afc42f1b6b9a803764316121485bd66db0d) Update vikunja-install.sh - [`446e01f`](https://github.com/community-scripts/ProxmoxVE/commit/446e01f67aa976d25d87bcc95ae9cb1af7397c56) update vikunja-install.sh ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/vikunja-install.sh` (+3 -1) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description This PR addresses an issue in which the Vikunja database (and files folder if created) gets deleted when the user updates Vikunja via the script. The change adds two more substitutions via the sed command to modify the default Vikunja config file; changes the location of the database file and the files folder to `/etc/vikunja`. Fixes #502 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) - **There is none, as far as I can tell**. ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?