[PR #847] [MERGED] Update Script: Remove Docker Compose Question #2717

Closed
opened 2025-11-20 05:31:28 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/847
Author: @michelroegl-brunner
Created: 12/16/2024
Status: Merged
Merged: 12/16/2024
Merged by: @MickLesk

Base: mainHead: docker-install


📝 Commits (1)

  • c32ee6e Update Script: Remove Docker Compose Question

📊 Changes

1 file changed (+0 additions, -9 deletions)

View changed files

📝 install/docker-install.sh (+0 -9)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.
Remove the Question to install Docker Compose. It gets automatically intsalled with the Docker install anyway.
The versions are the same, it dose not make a difference if you choose Composer or not.



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/847 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 12/16/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `docker-install` --- ### 📝 Commits (1) - [`c32ee6e`](https://github.com/community-scripts/ProxmoxVE/commit/c32ee6efe7fc29e2f51ec4db70eccb0acc0f1458) Update Script: Remove Docker Compose Question ### 📊 Changes **1 file changed** (+0 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `install/docker-install.sh` (+0 -9) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Provide a summary of the changes made and/or reference the issue being addressed. Remove the Question to install Docker Compose. It gets automatically intsalled with the Docker install anyway. The versions are the same, it dose not make a difference if you choose Composer or not. - - - - Related Issue: #829 - Related PR: # (if applicable) - Related Discussion: [Link](https://github.com/community-scripts/ProxmoxVE/discussions) --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [ ] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:31:28 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2717