SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 14:23:53 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #910] [MERGED] Enhance Tooltip component by adding CircleHelp icon and fix instructions in script component #2761

New Issue
Closed
opened 2025-11-20 05:31:40 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:31:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/910
Author: @BramSuurdje
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @MickLesk

Base: main ← Head: feat-add-icons-to-badges

📝 Commits (2)

  • 69a253f Enhance Tooltip component by adding CircleHelp icon and adjusting layout. Updated TooltipContent max width for better display.
  • b9d4a83 Refactor ScriptItem and InstallCommand components to improve conditional rendering based on item type. Updated text to clarify usage instructions for 'misc' type scripts.

📊 Changes

3 files changed (+12 additions, -8 deletions)

View changed files

📝 frontend/src/app/scripts/_components/ScriptItem.tsx (+1 -1)
📝 frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx (+6 -5)
📝 frontend/src/app/scripts/_components/ScriptItems/Tooltips.tsx (+5 -2)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

This pull request includes changes to improve the user interface and functionality of the script items in the application. The most important changes include modifying the conditions for displaying installation instructions, updating the tooltip components, and adding a new icon to the tooltip badges.

Changes to installation instructions:

Updates to tooltip components:

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

Badge Before:
image

Badge After:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/910 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `feat-add-icons-to-badges` --- ### 📝 Commits (2) - [`69a253f`](https://github.com/community-scripts/ProxmoxVE/commit/69a253f0e1ce16f10d50e01799446515f629fda4) Enhance Tooltip component by adding CircleHelp icon and adjusting layout. Updated TooltipContent max width for better display. - [`b9d4a83`](https://github.com/community-scripts/ProxmoxVE/commit/b9d4a83c6d70136a791e50f271a7b23851788891) Refactor ScriptItem and InstallCommand components to improve conditional rendering based on item type. Updated text to clarify usage instructions for 'misc' type scripts. ### 📊 Changes **3 files changed** (+12 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/scripts/_components/ScriptItem.tsx` (+1 -1) 📝 `frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx` (+6 -5) 📝 `frontend/src/app/scripts/_components/ScriptItems/Tooltips.tsx` (+5 -2) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Provide a summary of the changes made and/or reference the issue being addressed. This pull request includes changes to improve the user interface and functionality of the script items in the application. The most important changes include modifying the conditions for displaying installation instructions, updating the tooltip components, and adding a new icon to the tooltip badges. Changes to installation instructions: * [`frontend/src/app/scripts/_components/ScriptItem.tsx`](diffhunk://#diff-8211dae113b207283321d206905609d73b1aa3e743d4f716e01d02b9db590438L84-R84): Modified the condition to display "How to install" or "How to use" based on the `item.type` value. * [`frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx`](diffhunk://#diff-be78da33e0230b669a52fb99a71685a83ea2d01111097f121075354e41bcf7d7L31-R40): Updated the condition and text for displaying instructions based on the `item.type` value. Updates to tooltip components: * [`frontend/src/app/scripts/_components/ScriptItems/Tooltips.tsx`](diffhunk://#diff-c6ed439e012bdb7bde3a0a421ed362225e8c48fd4d3b09644e3172f0eca4f9a8R9): Imported the `CircleHelp` icon from `lucide-react`. * [`frontend/src/app/scripts/_components/ScriptItems/Tooltips.tsx`](diffhunk://#diff-c6ed439e012bdb7bde3a0a421ed362225e8c48fd4d3b09644e3172f0eca4f9a8L21-R26): Added the `CircleHelp` icon to the `TooltipBadge` component and adjusted the tooltip content's maximum width. - - - ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. Badge Before: <img width="302" alt="image" src="https://github.com/user-attachments/assets/953e52da-62a2-4e16-b890-44279282353e" /> Badge After: <img width="657" alt="image" src="https://github.com/user-attachments/assets/6d6344b3-bf26-41c6-8485-3ffea5a17a6d" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:31:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?