SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-27 02:21:45 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Firefly III LXC fetches unstable release versions #278

New Issue
Closed
opened 2025-11-20 04:46:07 -05:00 by saavagebueno · 8 comments
saavagebueno commented 2025-11-20 04:46:07 -05:00
Owner
Copy Link

Originally created by @alberanid on GitHub (Jan 2, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Firefly III LXC

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/firefly.sh)"

📝 Provide a clear and concise description of the issue.

By default, the newly introduced Firefly III LXC script fetches the latest available version of Firefly III, which most of the times is an alpha release.

I propose changing the current way to fetch tags:

curl -s https://api.github.com/repos/firefly-iii/firefly-iii/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4)}'

(which currently returns 6.2.0-alpha.1) with this one:

curl -L -s -H "Accept: application/vnd.github+json" https://api.github.com/repos/firefly-iii/firefly-iii/releases?per_page=50 | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}' | grep "^v" | grep -v '\-\(alpha\|beta\)' | sed 's/^v//' | head -1

(which returns 6.1.25)

I will provide a PR, soon.

Tagging @quantumryuu as the author of the PR.

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

Just install Firefly III LXC and check its version number.

❌ Paste the full error output (if available).

Not an error, but you're not expected to install software that is in alpha state.

🖼️ Additional context (optional).

image

Originally created by @alberanid on GitHub (Jan 2, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Firefly III LXC ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/firefly.sh)" ### 📝 Provide a clear and concise description of the issue. By default, the newly introduced Firefly III LXC script fetches the latest available version of Firefly III, which most of the times is an alpha release. I propose changing the current way to fetch tags: ``` curl -s https://api.github.com/repos/firefly-iii/firefly-iii/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4)}' ``` (which currently returns *6.2.0-alpha.1*) with this one: ``` curl -L -s -H "Accept: application/vnd.github+json" https://api.github.com/repos/firefly-iii/firefly-iii/releases?per_page=50 | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}' | grep "^v" | grep -v '\-\(alpha\|beta\)' | sed 's/^v//' | head -1 ``` (which returns *6.1.25*) I will provide a PR, soon. Tagging @quantumryuu as the author of the PR. ### ⚙️ What settings are you using? - [X] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. Just install Firefly III LXC and check its version number. ### ❌ Paste the full error output (if available). Not an error, but you're not expected to install software that is in alpha state. ### 🖼️ Additional context (optional). ![image](https://github.com/user-attachments/assets/3d7a056e-e61f-44c9-8aeb-86880ddd6860)
saavagebueno commented 2025-11-20 04:46:07 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 2, 2025):

It crawl the latest official Release. Thats correct. We dont improve the call. Its an firefly Maintenance topic.

@MickLesk commented on GitHub (Jan 2, 2025): It crawl the latest official Release. Thats correct. We dont improve the call. Its an firefly Maintenance topic.
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@alberanid commented on GitHub (Jan 2, 2025):

Understood. I've opened a discussion on the Firefly III project: https://github.com/orgs/firefly-iii/discussions/9610

@alberanid commented on GitHub (Jan 2, 2025): Understood. I've opened a discussion on the Firefly III project: https://github.com/orgs/firefly-iii/discussions/9610
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@quantumryuu commented on GitHub (Jan 2, 2025):

Hello @alberanid, I run the command the command that it's in the script to fetch the latest release, and I got the 6.1.25. I don't even know how you got the alpha release

@quantumryuu commented on GitHub (Jan 2, 2025): Hello @alberanid, I run the command the command that it's in the script to fetch the latest release, and I got the **6.1.25**. I don't even know how you got the alpha release
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 2, 2025):

Hello @alberanid, I run the command the command that it's in the script to fetch the latest release, and I got the 6.1.25. I don't even know how you got the alpha release

because the maintainer of firefly fixed it a few hours ago

@MickLesk commented on GitHub (Jan 2, 2025): > Hello @alberanid, I run the command the command that it's in the script to fetch the latest release, and I got the **6.1.25**. I don't even know how you got the alpha release because the maintainer of firefly fixed it a few hours ago
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@alberanid commented on GitHub (Jan 2, 2025):

because the maintainer of firefly fixed it a few hours ago

@quantumryuu as said by @MickLesk , the authors of Firefly III reverted the "latest" release to 6.1.25. They, however, seems to think that it's somehow normal to have an alpha as "latest": https://github.com/orgs/firefly-iii/discussions/9610#discussioncomment-11720130

Also, I don't know what will happen on an existing LXC now that the new "latest" tag is in fact older that the previous one. Am I wrong or the check is just on the whole version tag, and if they differ the latest version is installed anyway?

@alberanid commented on GitHub (Jan 2, 2025): > because the maintainer of firefly fixed it a few hours ago @quantumryuu as said by @MickLesk , the authors of Firefly III reverted the "latest" release to 6.1.25. They, however, seems to think that it's somehow normal to have an alpha as "latest": https://github.com/orgs/firefly-iii/discussions/9610#discussioncomment-11720130 Also, I don't know what will happen on an existing LXC now that the new "latest" tag is in fact older that the previous one. Am I wrong or the check is just on the whole version tag, and if they differ the latest version is installed anyway?
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@alberanid commented on GitHub (Jan 2, 2025):

to test the above described scenario, I cloned my current 6.2.0-alpha.1 installation and run update in it.

It fails with:

    _______           ______     
   / ____(_)_______  / __/ /_  __
  / /_  / / ___/ _ \/ /_/ / / / /
 / __/ / / /  /  __/ __/ / /_/ / 
/_/   /_/_/   \___/_/ /_/\__, /  
                        /____/   

  ✔️  Stopped Apache2
 ⠼ Updating Firefly to v6.1.25 
[ERROR] in line 51: exit code 0: while executing command composer install --no-dev --no-interaction &> /dev/null

(exit code: 1) and after that the LXC is completely broken.

Funny thing, manually running the update script line by line will be fine (exit code 0) at line composer install --no-dev --no-interaction (just a lot of warnings in the output) but fails at php artisan migrate --seed --force since it can't update the db:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'currentamount' in 'where clause' (Connection: mysql, SQL: select * from `piggy_bank_repetitions` where `currentamount` < 0)

So... yeah, people who installed the 6.2.0-alpha in the previous day will have a broken installation after today.

Let me know if I may help.

@alberanid commented on GitHub (Jan 2, 2025): to test the above described scenario, I cloned my current 6.2.0-alpha.1 installation and run `update` in it. It fails with: ``` _______ ______ / ____(_)_______ / __/ /_ __ / /_ / / ___/ _ \/ /_/ / / / / / __/ / / / / __/ __/ / /_/ / /_/ /_/_/ \___/_/ /_/\__, / /____/ ✔️ Stopped Apache2 ⠼ Updating Firefly to v6.1.25 [ERROR] in line 51: exit code 0: while executing command composer install --no-dev --no-interaction &> /dev/null ``` (exit code: 1) and after that the LXC is completely broken. Funny thing, manually running the update script line by line will be fine (exit code 0) at line `composer install --no-dev --no-interaction` (just a lot of warnings in the output) but fails at `php artisan migrate --seed --force` since it can't update the db: ``` SQLSTATE[42S22]: Column not found: 1054 Unknown column 'currentamount' in 'where clause' (Connection: mysql, SQL: select * from `piggy_bank_repetitions` where `currentamount` < 0) ``` So... yeah, people who installed the 6.2.0-alpha in the previous day will have a broken installation after today. Let me know if I may help.
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 2, 2025):

You cant downgrade this. Build an new LXC

@MickLesk commented on GitHub (Jan 2, 2025): You cant downgrade this. Build an new LXC
saavagebueno commented 2025-11-20 04:46:08 -05:00
Author
Owner
Copy Link

@alberanid commented on GitHub (Jan 2, 2025):

You cant downgrade this. Build an new LXC

Problem is that in a new LXC the code will be downgraded to 6.1.25, but my data right now was already migrated to 6.2.0-alpha.1 and they are no longer compatible. (also, migration and backup/restore of Firefly III data is not exactly an easy task and I'd prefer to not start again from zero).

Anyway, I guess very few people have installed the 6.2.0-alpha.1 version, so it's probably not a big deal.

@alberanid commented on GitHub (Jan 2, 2025): > You cant downgrade this. Build an new LXC Problem is that in a new LXC the code will be downgraded to 6.1.25, but my data right now was already migrated to 6.2.0-alpha.1 and they are no longer compatible. (also, migration and backup/restore of Firefly III data is not exactly an easy task and I'd prefer to not start again from zero). Anyway, I guess very few people have installed the 6.2.0-alpha.1 version, so it's probably not a big deal.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?