SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1060] [MERGED] feat: allow adding SSH authorized key for root (advanced settings) #2824

New Issue
Open
opened 2025-11-20 05:32:01 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:32:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1060
Author: @dsiebel
Created: 12/28/2024
Status: ✅ Merged
Merged: 12/28/2024
Merged by: @MickLesk

Base: develop ← Head: ssh-authorized-key-develop

📝 Commits (1)

  • 042cba8 feat: allow adding SSH authorized key for root (advanced settings)

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 misc/build.func (+5 -0)
📝 misc/install.func (+7 -0)

📄 Description

✍️ Description

Adds and additional input to the advanced settings flow that allows adding an SSH authorized key for the root user.

  • Related Discussion: #860

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

I came up with multiple ways to implement this, but ultimately decided to go for the most pragmatic one to get a feel first.
Other possible implementation I had in mind:

  • option to forward authorized_keys from the PVE host (multi select menu) to the newly created container / vm
  • use a "well-known" file location or environment variable to contain the SSH key to authorize

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1060 **Author:** [@dsiebel](https://github.com/dsiebel) **Created:** 12/28/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `develop` ← **Head:** `ssh-authorized-key-develop` --- ### 📝 Commits (1) - [`042cba8`](https://github.com/community-scripts/ProxmoxVE/commit/042cba8c07a80ac548ecb20e1776552d69345e4a) feat: allow adding SSH authorized key for root (advanced settings) ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+5 -0) 📝 `misc/install.func` (+7 -0) </details> ### 📄 Description ## ✍️ Description Adds and additional input to the advanced settings flow that allows adding an SSH authorized key for the root user. - Related Discussion: #860 --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) I came up with multiple ways to implement this, but ultimately decided to go for the most pragmatic one to get a feel first. Other possible implementation I had in mind: - option to forward authorized_keys from the PVE host (multi select menu) to the newly created container / vm - use a "well-known" file location or environment variable to contain the SSH key to authorize --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:32:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?