SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-06-10 17:32:10 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1076] [MERGED] New Script: Grist #2836

New Issue
Closed
opened 2025-11-20 05:32:05 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:32:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1076
Author: @cfurrow
Created: 12/28/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @michelroegl-brunner

Base: main ← Head: grist

📝 Commits (10+)

  • 8cbcfc8 feat: create grist helper scripts, and json
  • 5c5d4d0 fix: move rm of zip into "clean up"
  • 5e75cb2 fix: remove second source
  • b111235 fix: include 'v' in release messages
  • c80616c fix: use full path to remove release zip
  • 6e3666c fix: update copyright
  • 6b04f76 fix: combine nodejs installers into one section
  • 25bbadb fix: comment spacing
  • 75676a4 fix: copy .env file from existing grist_bak dir
  • 563f168 fix: ensure "install:python" is run to install python deps

📊 Changes

3 files changed (+196 additions, -0 deletions)

View changed files

➕ ct/grist.sh (+78 -0)
➕ install/grist-install.sh (+84 -0)
➕ json/grist.json (+34 -0)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Adding new script to install and update Grist (https://www.getgrist.com/).

Note: I'm new to Proxmox and Helper-Scripts, and I've not used Grist until I began to create these scripts. I wanted to try out Grist, and I had just recently created a Proxmox node, so I thought I'd try my hand at creating helper scripts to get Grist up and running on my Proxmox node.

I used the homarr scripts/json as a guide to create this PR.

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
    • In another branch I did a find/replace to update wget/source calls from community-scripts/ProxmoxVE/raw/main to my test branch, cfurrow/ProxmoxVE/tree/grist-dev. Then I was able to verify the initial install, and update scripts worked.
  • Documentation updated (I have updated any relevant documentation)
    • ⚠️ I don't know if I've done this, and I don't know what other documentation outside of the new grist.json would need updating? Maybe new scripts do not need doc updates?

📋 Additional Information (optional)

As mentioned in the above description--I'm new to Proxmox, and Helper Scripts, so I'd appreciate any guidance and feedback on this PR. I'm hoping most of it is OK since I copied from the existing "homarr" scripts.

Something that I hope to see in the future for the helper scripts is a tutorial/guide for writing new scripts, as well as some additional quality of life updates for developers. Having to manually change the URLs so that your local proxmox will use your own repo files is a bit cumbersome, as you then have to revert those changes before pushing up to your final branch. Maybe there is already a way to "bootstrap" some basic details, such as the base repo which could obviate the need to do a find/replace and instead set those details in a .env file or similar. Simply spitballing and this may already be underway by the community.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1076 **Author:** [@cfurrow](https://github.com/cfurrow) **Created:** 12/28/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `grist` --- ### 📝 Commits (10+) - [`8cbcfc8`](https://github.com/community-scripts/ProxmoxVE/commit/8cbcfc82d9be29563ad8d1b92c4d78f508af3cc3) feat: create grist helper scripts, and json - [`5c5d4d0`](https://github.com/community-scripts/ProxmoxVE/commit/5c5d4d058e34e03db85d5d9779258649a9dd100f) fix: move rm of zip into "clean up" - [`5e75cb2`](https://github.com/community-scripts/ProxmoxVE/commit/5e75cb20b92a98456cda10728733cb3a4d78a0f1) fix: remove second source - [`b111235`](https://github.com/community-scripts/ProxmoxVE/commit/b111235a0c7067501408169f12df22b41f6c5a0a) fix: include 'v' in release messages - [`c80616c`](https://github.com/community-scripts/ProxmoxVE/commit/c80616c21ec161a3850bee43234b50805d352bd8) fix: use full path to remove release zip - [`6e3666c`](https://github.com/community-scripts/ProxmoxVE/commit/6e3666c4ff403ad685cc4931b08d3556ec0853ba) fix: update copyright - [`6b04f76`](https://github.com/community-scripts/ProxmoxVE/commit/6b04f76e98fcade77f607ab7a2b56ffded358466) fix: combine nodejs installers into one section - [`25bbadb`](https://github.com/community-scripts/ProxmoxVE/commit/25bbadbca9b5a5fbced438603a9665783071d2a1) fix: comment spacing - [`75676a4`](https://github.com/community-scripts/ProxmoxVE/commit/75676a4106797558e805ce7850d4726f178cf531) fix: copy .env file from existing grist_bak dir - [`563f168`](https://github.com/community-scripts/ProxmoxVE/commit/563f168b07b531e80da7fc5b439616f16fc9e0b8) fix: ensure "install:python" is run to install python deps ### 📊 Changes **3 files changed** (+196 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/grist.sh` (+78 -0) ➕ `install/grist-install.sh` (+84 -0) ➕ `json/grist.json` (+34 -0) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Adding new script to install and update Grist (https://www.getgrist.com/). Note: I'm new to Proxmox and Helper-Scripts, and I've not used Grist until I began to create these scripts. I wanted to try out Grist, and I had just recently created a Proxmox node, so I thought I'd try my hand at creating helper scripts to get Grist up and running on my Proxmox node. I used the homarr scripts/json as a guide to create this PR. --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [x] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - In another branch I did a find/replace to update wget/source calls from `community-scripts/ProxmoxVE/raw/main` to my test branch, `cfurrow/ProxmoxVE/tree/grist-dev`. Then I was able to verify the initial install, and update scripts worked. - [ ] Documentation updated (I have updated any relevant documentation) - ⚠️ I don't know if I've done this, and I don't know what other documentation outside of the new `grist.json` would need updating? Maybe new scripts do not need doc updates? --- ## 📋 Additional Information (optional) As mentioned in the above description--I'm new to Proxmox, and Helper Scripts, so I'd appreciate any guidance and feedback on this PR. I'm hoping most of it is OK since I copied from the existing "homarr" scripts. Something that I hope to see in the future for the helper scripts is a tutorial/guide for writing new scripts, as well as some additional quality of life updates for developers. Having to manually change the URLs so that your local proxmox will use your own repo files is a bit cumbersome, as you then have to revert those changes before pushing up to your final branch. Maybe there is already a way to "bootstrap" some basic details, such as the base repo which could obviate the need to do a find/replace and instead set those details in a `.env` file or similar. Simply spitballing and this may already be underway by the community. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:32:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2836
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?