SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 14:23:53 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1155] [MERGED] Fix Script Homepage: add version during build step #2868

New Issue
Closed
opened 2025-11-20 05:32:15 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:32:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1155
Author: @se-bastiaan
Created: 1/1/2025
Status: ✅ Merged
Merged: 1/1/2025
Merged by: @MickLesk

Base: main ← Head: fix/homepage-version

📝 Commits (2)

  • fb5f356 Make variables exported
  • d50b37d Auto-yes update-browserslist-db

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 ct/homepage.sh (+3 -1)
📝 install/homepage-install.sh (+2 -0)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

This pull request includes updates to the scripts responsible for installing and updating the homepage application. The changes primarily focus on setting environment variables and ensuring the latest version of the browserslist database is used.

Updates to environment variables and dependency management:

  • ct/homepage.sh: Added --yes flag to npx update-browserslist-db@latest to automatically confirm updates (closes #1152), and set NEXT_PUBLIC_VERSION and NEXT_PUBLIC_REVISION environment variables before building the project (closes #1062).
  • install/homepage-install.sh: Added NEXT_PUBLIC_VERSION and NEXT_PUBLIC_REVISION environment variables before building the project to ensure the build process has the necessary versioning information (closes #1062).

In comparison to the original #1107 this PR exports the required variables in the shell scripts instead of providing them directly with the build command. This is not possible since the $STD silent option sees the variables as separate commands instead of information for pnpm build. And this time I have missed

Let me know if we want to make this testable first, so that I can change the urls.

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1155 **Author:** [@se-bastiaan](https://github.com/se-bastiaan) **Created:** 1/1/2025 **Status:** ✅ Merged **Merged:** 1/1/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix/homepage-version` --- ### 📝 Commits (2) - [`fb5f356`](https://github.com/community-scripts/ProxmoxVE/commit/fb5f35605c705d7accde0ab92f88de87403dbbbf) Make variables exported - [`d50b37d`](https://github.com/community-scripts/ProxmoxVE/commit/d50b37d4da22565a2135db5566454356e38a701c) Auto-yes update-browserslist-db ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ct/homepage.sh` (+3 -1) 📝 `install/homepage-install.sh` (+2 -0) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description This pull request includes updates to the scripts responsible for installing and updating the homepage application. The changes primarily focus on setting environment variables and ensuring the latest version of the `browserslist` database is used. ### Updates to environment variables and dependency management: * [`ct/homepage.sh`](diffhunk://#diff-5e706703158f4b406e5cb906477e30a8eae0a623969866bf7d1f46fdcea69201L53-R56): Added `--yes` flag to `npx update-browserslist-db@latest` to automatically confirm updates (closes #1152), and set `NEXT_PUBLIC_VERSION` and `NEXT_PUBLIC_REVISION` environment variables before building the project (closes #1062). * [`install/homepage-install.sh`](diffhunk://#diff-c29df5fa995f8f78893b692af5fbd9ef3b3b531741df232aecb876f98194e583R46-R47): Added `NEXT_PUBLIC_VERSION` and `NEXT_PUBLIC_REVISION` environment variables before building the project to ensure the build process has the necessary versioning information (closes #1062). In comparison to the original #1107 this PR exports the required variables in the shell scripts instead of providing them directly with the build command. This is not possible since the $STD silent option sees the variables as separate commands instead of information for pnpm build. And this time I have missed Let me know if we want to make this testable first, so that I can change the urls. - - - - Related Issue: #1062 #1118 #1152 - Related PR: #1107 --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:32:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?