SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 06:13:56 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1301] [MERGED] Update rest of build func #2939

New Issue
Open
opened 2025-11-20 05:32:38 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:32:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1301
Author: @cricalix
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @michelroegl-brunner

Base: dev_overrideable_url ← Head: update-rest-of-build-func

📝 Commits (5)

  • d661b27 Redo: Change from wget to curl when fetching create_lxc.sh
  • 4ca6da2 Redo: [overrideable url] Initial changes to ct scripts to use environment variable
  • ad9b914 Redo: [overrideable url] Remaining changes to ct scripts to use environment variable
  • 46b66e1 Redo: [overrideable url] Update build.func to use overrideable URL
  • 7438f12 Merge branch 'dev_overrideable_url' into update-rest-of-build-func

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 misc/build.func (+5 -4)

📄 Description

✍️ Description

In https://github.com/community-scripts/ProxmoxVE/discussions/1202, I proposed that a new environment variable could be used to change the URL that the scripts fetch data from, enabling easy testing against custom repositories (or even local disk) without having to edit the files every time. In https://github.com/community-scripts/ProxmoxVE/pull/1230, the request was made to split the PR into smaller PRs.

This PR implements the remaining changes to the build.func file, replacing static URLs with variable-based URLs.

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Previous PR screenshots apply.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1301 **Author:** [@cricalix](https://github.com/cricalix) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `dev_overrideable_url` ← **Head:** `update-rest-of-build-func` --- ### 📝 Commits (5) - [`d661b27`](https://github.com/community-scripts/ProxmoxVE/commit/d661b27ee3e14b71140dc7bc38635905b9df4148) Redo: Change from wget to curl when fetching create_lxc.sh - [`4ca6da2`](https://github.com/community-scripts/ProxmoxVE/commit/4ca6da2e5c16213d155fa2ad77848dcd91495216) Redo: [overrideable url] Initial changes to ct scripts to use environment variable - [`ad9b914`](https://github.com/community-scripts/ProxmoxVE/commit/ad9b914a240450c8ced1b0b58e79ef00bd80b802) Redo: [overrideable url] Remaining changes to ct scripts to use environment variable - [`46b66e1`](https://github.com/community-scripts/ProxmoxVE/commit/46b66e198a22450b0ad101b64e3579ad06cb387c) Redo: [overrideable url] Update build.func to use overrideable URL - [`7438f12`](https://github.com/community-scripts/ProxmoxVE/commit/7438f125d8683810272dfcdc6d6390173810db2e) Merge branch 'dev_overrideable_url' into update-rest-of-build-func ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+5 -4) </details> ### 📄 Description ## ✍️ Description In https://github.com/community-scripts/ProxmoxVE/discussions/1202, I proposed that a new environment variable could be used to change the URL that the scripts fetch data from, enabling easy testing against custom repositories (or even local disk) without having to edit the files every time. In https://github.com/community-scripts/ProxmoxVE/pull/1230, the request was made to split the PR into smaller PRs. This PR implements the remaining changes to the build.func file, replacing static URLs with variable-based URLs. - - - - Related PR: #1252 - Related Discussion: #1202 --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] ~Documentation updated (I have updated any relevant documentation)~ --- ## 📋 Additional Information (optional) Previous PR screenshots apply. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:32:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?