SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-22 05:52:48 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1402] [MERGED] Update Prometheus + Alertmanager: Unify scripts for easier maintenance #3007

New Issue
Closed
opened 2025-11-20 05:32:57 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:32:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1402
Author: @andygrunwald
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @MickLesk

Base: main ← Head: adjust-prometheus-alertmanager

📝 Commits (1)

  • 2a8590c Prometheus + Alertmanager: Unify scripts for easier maintenance

📊 Changes

3 files changed (+22 additions, -23 deletions)

View changed files

📝 ct/prometheus-alertmanager.sh (+3 -4)
📝 ct/prometheus.sh (+6 -7)
📝 install/prometheus-install.sh (+13 -12)

📄 Description

✍️ Description

Recently, Prometheus Alertmanager was merged, see https://github.com/community-scripts/ProxmoxVE/pull/1272

Alertmanager is very similar in the installation as Prometheus.
This Pull Request unifies the scripts for Prometheus and Alertmanager, based of the feedback from https://github.com/community-scripts/ProxmoxVE/pull/1272.

In particular:

  • Using absolute pathes
  • Prefixing ${RELEASE} with v
  • Running update functions in /opt and not in ~
  • Fixing a bug in the Alertmanager Update script (the rm -rf should fail, as we (originally) cded into the unpacked folder, but did not cd ..`)

For Prometheus, there is no functional change.
This is just a unification of both scripts.

🛠️ Type of Change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1402 **Author:** [@andygrunwald](https://github.com/andygrunwald) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `adjust-prometheus-alertmanager` --- ### 📝 Commits (1) - [`2a8590c`](https://github.com/community-scripts/ProxmoxVE/commit/2a8590c081bbba0884dfec16c4cd9a6a9bac0ee4) Prometheus + Alertmanager: Unify scripts for easier maintenance ### 📊 Changes **3 files changed** (+22 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `ct/prometheus-alertmanager.sh` (+3 -4) 📝 `ct/prometheus.sh` (+6 -7) 📝 `install/prometheus-install.sh` (+13 -12) </details> ### 📄 Description ## ✍️ Description Recently, Prometheus Alertmanager was merged, see https://github.com/community-scripts/ProxmoxVE/pull/1272 Alertmanager is _very_ similar in the installation as Prometheus. This Pull Request unifies the scripts for Prometheus and Alertmanager, based of the feedback from https://github.com/community-scripts/ProxmoxVE/pull/1272. In particular: * Using absolute pathes * Prefixing ${RELEASE} with `v` * Running update functions in `/opt` and not in `~` * Fixing a bug in the Alertmanager Update script (the `rm -rf` should fail, as we (originally) cd`ed into the unpacked folder, but did not `cd ..`) For Prometheus, there is no functional change. This is just a unification of both scripts. --- ## 🛠️ Type of Change - [X] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:32:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3007
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?