SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1540] [MERGED] Update Openwrt: Delete lines that do WAN input and forward accept #3077

New Issue
Closed
opened 2025-11-20 05:33:17 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:33:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1540
Author: @chackl1990
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @michelroegl-brunner

Base: main ← Head: main

📝 Commits (1)

  • 96f1f4a Delete WAN input and forward accept

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 vm/openwrt.sh (+0 -2)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Deleted 2 lines of the script that would open the WAN interface for input and forward, as this would expose the ports of OpenWRT to the WAN

Please remove unneeded lines!

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

The script allowed input on WAN, so everyone who used the script and did not fix it, may have an open WAN port.
This can be fixed by logig in to Luci Web Interface and navigate to Network -> Firewall and get the Zone-Settings like this:
WRT-FW-WAN-Input

If you like to use ssh / cli than this needs to be send to the VM:
uci set firewall.@zone[1].input='REJECT'
uci set firewall.@zone[1].forward='REJECT'
uci commit
reboot

Executing the script again would not help. Also if you restore the config by OpenWRT, the WAN-Input-Accept would also be restored and stays on accept.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1540 **Author:** [@chackl1990](https://github.com/chackl1990) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`96f1f4a`](https://github.com/community-scripts/ProxmoxVE/commit/96f1f4a815aac8b27550a9a057990bb6aa3f2294) Delete WAN input and forward accept ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `vm/openwrt.sh` (+0 -2) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Deleted 2 lines of the script that would open the WAN interface for input and forward, as this would expose the ports of OpenWRT to the WAN - - - **_Please remove unneeded lines!_** --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) The script allowed input on WAN, so everyone who used the script and did not fix it, may have an open WAN port. This can be fixed by logig in to Luci Web Interface and navigate to Network -> Firewall and get the Zone-Settings like this: ![WRT-FW-WAN-Input](https://github.com/user-attachments/assets/cfbff229-489d-4bcd-9270-9300745a95db) If you like to use ssh / cli than this needs to be send to the VM: `uci set firewall.@zone[1].input='REJECT'` `uci set firewall.@zone[1].forward='REJECT'` `uci commit` `reboot` Executing the script again would not help. Also if you restore the config by OpenWRT, the WAN-Input-Accept would also be restored and stays on accept. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:33:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?