SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1697] [MERGED] Refactor ScriptInfoBlocks and siteConfig to properly show the most populair scripts #3166

New Issue
Closed
opened 2025-11-20 05:33:45 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:33:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1697
Author: @BramSuurdje
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @michelroegl-brunner

Base: main ← Head: main

📝 Commits (2)

  • 4dfc587 Refactor ScriptInfoBlocks and siteConfig to properly show the most populair scripts
  • 6e9ebcc Merge branch 'main' of github.com:BramSuurdje/ProxmoxVE

📊 Changes

2 files changed (+4 additions, -8 deletions)

View changed files

📝 frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx (+3 -3)
📝 frontend/src/config/siteConfig.tsx (+1 -5)

📄 Description

✍️ Description

This pull request includes several changes to the frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx and frontend/src/config/siteConfig.tsx files to improve the handling of script identifiers and layout consistency.

Changes to script identifiers and layout:

  • Related Issue: fixes #1691
  • Related PR: #
  • Related Discussion: #

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1697 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`4dfc587`](https://github.com/community-scripts/ProxmoxVE/commit/4dfc587057c05ecab8ba3df8194f899ad07e8945) Refactor ScriptInfoBlocks and siteConfig to properly show the most populair scripts - [`6e9ebcc`](https://github.com/community-scripts/ProxmoxVE/commit/6e9ebccba10c56ff61b06bfa8fc3f5c0120ce0b2) Merge branch 'main' of github.com:BramSuurdje/ProxmoxVE ### 📊 Changes **2 files changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx` (+3 -3) 📝 `frontend/src/config/siteConfig.tsx` (+1 -5) </details> ### 📄 Description ## ✍️ Description This pull request includes several changes to the `frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx` and `frontend/src/config/siteConfig.tsx` files to improve the handling of script identifiers and layout consistency. Changes to script identifiers and layout: * [`frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx`](diffhunk://#diff-879c319f50f0a92482cc7228edea097072191aff8564256c5e47549c3bd3ffe0L93-R93): Modified the `LatestScripts` function to ensure consistent width for script logos by adding `min-w-16` to the class list. * [`frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx`](diffhunk://#diff-879c319f50f0a92482cc7228edea097072191aff8564256c5e47549c3bd3ffe0L145-R145): Updated the `MostViewedScripts` function to use `script.slug` instead of `script.name` for filtering the most popular scripts. * [`frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx`](diffhunk://#diff-879c319f50f0a92482cc7228edea097072191aff8564256c5e47549c3bd3ffe0L165-R165): Adjusted the layout of the script logo container in the `MostViewedScripts` function to use a new class `size-16` for consistent sizing. * [`frontend/src/config/siteConfig.tsx`](diffhunk://#diff-0baba4dc08677b4a0aeea59e4dd7b3c43254f50f04a44e450a1d277b62c7e0c3L45-R45): Changed the entries in the `mostPopularScripts` array to use slugs instead of names for consistency and better matching with script identifiers. - - - - Related Issue: fixes #1691 - Related PR: # - Related Discussion: # - - - ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. ![image](https://github.com/user-attachments/assets/df4788dc-4941-4afd-a07f-f3e68bd6fd0d) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:33:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?