[PR #1785] [MERGED] Added change of the mobile GUI to disable nag request #3215

Closed
opened 2025-11-20 06:03:35 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1785
Author: @GarryG
Created: 1/27/2025
Status: Merged
Merged: 1/27/2025
Merged by: @MickLesk

Base: mainHead: PMG-Mobile-NagRequest


📝 Commits (1)

  • b8daf69 Added change of the mobile GUI to disable nag request

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 misc/post-pmg-install.sh (+4 -1)

📄 Description

✍️ Description

The PMG post-install patcher script only removed the nag request for desktop clients. For mobile clients, it still popped up the warning. The branch fixes this (make sure you clear your cache on your mobile device)



Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1785 **Author:** [@GarryG](https://github.com/GarryG) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/27/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `PMG-Mobile-NagRequest` --- ### 📝 Commits (1) - [`b8daf69`](https://github.com/community-scripts/ProxmoxVE/commit/b8daf690e80a35773455cacc513a0b7bc27b0a22) Added change of the mobile GUI to disable nag request ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `misc/post-pmg-install.sh` (+4 -1) </details> ### 📄 Description ## ✍️ Description The PMG post-install patcher script only removed the nag request for desktop clients. For mobile clients, it still popped up the warning. The branch fixes this (make sure you clear your cache on your mobile device) - - - - Related Issue: #1784 - Related PR: # - Related Discussion: # - - - ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:03:35 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3215