SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1805] [MERGED] New Script: Prometheus Proxmox VE Exporter #3226

New Issue
Open
opened 2025-11-20 06:03:39 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:03:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1805
Author: @andygrunwald
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @michelroegl-brunner

Base: main ← Head: prometheus-pve-exporter-container

📝 Commits (10+)

  • 8645c8e New Script: Prometheus Proxmox VE Exporter
  • a6f450c Fix formatting of config file output after installation
  • 90ea9cc Prometheus Proxmox VE Exporter: Set category 1 for Website
  • 4c894d2 Removed blank lines
  • fdc09ac Remove python3-dev, as it was commented out
  • 0fd95c6 Prometheus Proxmox VE Exporter: Move configuration under /opt
  • 8fb1fe5 Prometheus Proxmox VE Exporter: Add logo
  • 88846c6 Change msg_info "Updating Python3" to msg_info "Setup Python3"
  • eac423c Removed empty line
  • 94d465c Add note about Proxmox credentials into the website

📊 Changes

3 files changed (+167 additions, -0 deletions)

View changed files

➕ ct/prometheus-pve-exporter.sh (+57 -0)
➕ install/prometheus-pve-exporter-install.sh (+70 -0)
➕ json/prometheus-pve-exporter.json (+40 -0)

📄 Description

✍️ Description

This PR introduces a new Container Script for https://github.com/prometheus-pve/prometheus-pve-exporter

✅ Prerequisites

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • [] Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

My own testing was not done fully.
I followed the Contribution Guide at https://github.com/community-scripts/ProxmoxVE/blob/main/.github/CONTRIBUTOR_GUIDE/ct/AppName.md#12-import-functions and changed the import function, but for some reason the install/prometheus-pve-exporter-install.sh is not getting executed during install.

Any guidance?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1805 **Author:** [@andygrunwald](https://github.com/andygrunwald) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `prometheus-pve-exporter-container` --- ### 📝 Commits (10+) - [`8645c8e`](https://github.com/community-scripts/ProxmoxVE/commit/8645c8e78870765eeec92ad796e6319d5890aeb3) New Script: Prometheus Proxmox VE Exporter - [`a6f450c`](https://github.com/community-scripts/ProxmoxVE/commit/a6f450ceae69d02371fa32f0fdc631e2da11af4c) Fix formatting of config file output after installation - [`90ea9cc`](https://github.com/community-scripts/ProxmoxVE/commit/90ea9cc0ab22059df7a507ff424d2248c84952d4) Prometheus Proxmox VE Exporter: Set category 1 for Website - [`4c894d2`](https://github.com/community-scripts/ProxmoxVE/commit/4c894d24c0b5fb725f036a202518c09f08b8443c) Removed blank lines - [`fdc09ac`](https://github.com/community-scripts/ProxmoxVE/commit/fdc09aca1f650688056c4e4aef21202484c80cc8) Remove `python3-dev`, as it was commented out - [`0fd95c6`](https://github.com/community-scripts/ProxmoxVE/commit/0fd95c67d135aba6c2f6cd37501bd50f59858a82) Prometheus Proxmox VE Exporter: Move configuration under /opt - [`8fb1fe5`](https://github.com/community-scripts/ProxmoxVE/commit/8fb1fe5db0ecbd7d1ec3342840fcc7716350dc3d) Prometheus Proxmox VE Exporter: Add logo - [`88846c6`](https://github.com/community-scripts/ProxmoxVE/commit/88846c6df1167755aa5f61fd2d58d4cdd2d6f95c) Change `msg_info "Updating Python3"` to `msg_info "Setup Python3"` - [`eac423c`](https://github.com/community-scripts/ProxmoxVE/commit/eac423cea96928d8d92911322ab8c158d4ef3bf5) Removed empty line - [`94d465c`](https://github.com/community-scripts/ProxmoxVE/commit/94d465cf92dc678a37a62f7c921df856e994cc24) Add note about Proxmox credentials into the website ### 📊 Changes **3 files changed** (+167 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/prometheus-pve-exporter.sh` (+57 -0) ➕ `install/prometheus-pve-exporter-install.sh` (+70 -0) ➕ `json/prometheus-pve-exporter.json` (+40 -0) </details> ### 📄 Description ## ✍️ Description This PR introduces a new Container Script for https://github.com/prometheus-pve/prometheus-pve-exporter - - - - Related Discussion: https://github.com/community-scripts/ProxmoxVE/discussions/1006 - - - ## ✅ Prerequisites - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change - [] Bug fix (non-breaking change that resolves an issue) - [] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [X] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) My own testing was not done fully. I followed the Contribution Guide at https://github.com/community-scripts/ProxmoxVE/blob/main/.github/CONTRIBUTOR_GUIDE/ct/AppName.md#12-import-functions and changed the import function, but for some reason the `install/prometheus-pve-exporter-install.sh` is not getting executed during install. Any guidance? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:03:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3226
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?