SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-08 23:22:25 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #1805] New Script: Prometheus Proxmox VE Exporter #3228

New Issue
Closed
opened 2025-11-20 06:03:39 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:03:39 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/1805

State: closed
Merged: Yes

✍️ Description

This PR introduces a new Container Script for https://github.com/prometheus-pve/prometheus-pve-exporter

✅ Prerequisites

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • [] Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

My own testing was not done fully.
I followed the Contribution Guide at https://github.com/community-scripts/ProxmoxVE/blob/main/.github/CONTRIBUTOR_GUIDE/ct/AppName.md#12-import-functions and changed the import function, but for some reason the install/prometheus-pve-exporter-install.sh is not getting executed during install.

Any guidance?

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/1805 **State:** closed **Merged:** Yes --- ## ✍️ Description This PR introduces a new Container Script for https://github.com/prometheus-pve/prometheus-pve-exporter - - - - Related Discussion: https://github.com/community-scripts/ProxmoxVE/discussions/1006 - - - ## ✅ Prerequisites - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change - [] Bug fix (non-breaking change that resolves an issue) - [] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [X] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) My own testing was not done fully. I followed the Contribution Guide at https://github.com/community-scripts/ProxmoxVE/blob/main/.github/CONTRIBUTOR_GUIDE/ct/AppName.md#12-import-functions and changed the import function, but for some reason the `install/prometheus-pve-exporter-install.sh` is not getting executed during install. Any guidance?
saavagebueno added the pull-request label 2025-11-20 06:03:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?