SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2199] [MERGED] Fix: Crafty-Controller java versions and set default #3484

New Issue
Closed
opened 2025-11-20 06:05:05 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:05:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2199
Author: @CrazyWolf13
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix-java-crafty-controller

📝 Commits (4)

  • d7b5db4 add: java23, fix java-default
  • 623acd4 use temurin repo
  • 003921d Merge branch 'community-scripts:main' into fix-java-crafty-controller
  • ca46ebf refactor temurin part

📊 Changes

1 file changed (+14 additions, -5 deletions)

View changed files

📝 install/crafty-controller-install.sh (+14 -5)

📄 Description

✍️ Description

This PR fixes an issue, pointed out in crafty discord.
Before there was no real java-default set, so if a user selected "Do not override" java, then the server failed to start.
I also added java23, to give us some headroom, and ensure compatiblity with more server versions of minecraft.

  • Related Issue: #
  • Related PR: #
  • Related Discussion: #

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2199 **Author:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix-java-crafty-controller` --- ### 📝 Commits (4) - [`d7b5db4`](https://github.com/community-scripts/ProxmoxVE/commit/d7b5db49ae72e1296cb1670b33fe42cc9267f168) add: java23, fix java-default - [`623acd4`](https://github.com/community-scripts/ProxmoxVE/commit/623acd4a0e3ad329ade62fdc34f5a4654543e1d0) use temurin repo - [`003921d`](https://github.com/community-scripts/ProxmoxVE/commit/003921dade3e657c9b9774d151e83f484b20edd2) Merge branch 'community-scripts:main' into fix-java-crafty-controller - [`ca46ebf`](https://github.com/community-scripts/ProxmoxVE/commit/ca46ebfce278b928fbd44db32278837732486177) refactor temurin part ### 📊 Changes **1 file changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `install/crafty-controller-install.sh` (+14 -5) </details> ### 📄 Description ## ✍️ Description This PR fixes an issue, pointed out in crafty discord. Before there was no real java-default set, so if a user selected "Do not override" java, then the server failed to start. I also added java23, to give us some headroom, and ensure compatiblity with more server versions of minecraft. - - - - Related Issue: # - Related PR: # - Related Discussion: # - - - ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:05:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?