SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-06-07 16:02:12 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2351] [MERGED] [core] cleanup (remove base_settings & unneeded comments) #3610

New Issue
Closed
opened 2025-11-20 06:05:47 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:05:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2351
Author: @MickLesk
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/13/2025
Merged by: @michelroegl-brunner

Base: main ← Head: cleanup_ct

📝 Commits (1)

  • 5570195 [core] cleanup (remove base_settings & unneeded comments)

📊 Changes

241 files changed (+9 additions, -974 deletions)

View changed files

📝 .github/CONTRIBUTOR_GUIDE/ct/AppName.md (+0 -5)
📝 .github/CONTRIBUTOR_GUIDE/ct/AppName.sh (+0 -4)
📝 ct/2fauth.sh (+0 -4)
📝 ct/actualbudget.sh (+0 -4)
📝 ct/adguard.sh (+0 -4)
📝 ct/adventurelog.sh (+0 -4)
📝 ct/agentdvr.sh (+0 -4)
📝 ct/alpine-docker.sh (+0 -4)
📝 ct/alpine-grafana.sh (+0 -4)
📝 ct/alpine-it-tools.sh (+0 -4)
📝 ct/alpine-nextcloud.sh (+1 -5)
📝 ct/alpine-vaultwarden.sh (+0 -4)
📝 ct/alpine-zigbee2mqtt.sh (+0 -4)
📝 ct/alpine.sh (+0 -4)
📝 ct/apache-cassandra.sh (+0 -4)
📝 ct/apache-couchdb.sh (+0 -4)
📝 ct/apache-guacamole.sh (+0 -4)
📝 ct/apache-tika.sh (+0 -4)
📝 ct/apt-cacher-ng.sh (+0 -4)
📝 ct/archivebox.sh (+0 -4)

...and 80 more files

📄 Description

✍️ Description

  • remove base_settings (already declared in build.func)
  • remove unneeded comments
  • remove unneeded empty lines

🔗 Related PR / Discussion / Issue

  • generel cleanup

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

  • ✨ New feature – Adds new, non-breaking functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2351 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `cleanup_ct` --- ### 📝 Commits (1) - [`5570195`](https://github.com/community-scripts/ProxmoxVE/commit/55701952937bf641810d10c0b9b9afed3b1f8fac) [core] cleanup (remove base_settings & unneeded comments) ### 📊 Changes **241 files changed** (+9 additions, -974 deletions) <details> <summary>View changed files</summary> 📝 `.github/CONTRIBUTOR_GUIDE/ct/AppName.md` (+0 -5) 📝 `.github/CONTRIBUTOR_GUIDE/ct/AppName.sh` (+0 -4) 📝 `ct/2fauth.sh` (+0 -4) 📝 `ct/actualbudget.sh` (+0 -4) 📝 `ct/adguard.sh` (+0 -4) 📝 `ct/adventurelog.sh` (+0 -4) 📝 `ct/agentdvr.sh` (+0 -4) 📝 `ct/alpine-docker.sh` (+0 -4) 📝 `ct/alpine-grafana.sh` (+0 -4) 📝 `ct/alpine-it-tools.sh` (+0 -4) 📝 `ct/alpine-nextcloud.sh` (+1 -5) 📝 `ct/alpine-vaultwarden.sh` (+0 -4) 📝 `ct/alpine-zigbee2mqtt.sh` (+0 -4) 📝 `ct/alpine.sh` (+0 -4) 📝 `ct/apache-cassandra.sh` (+0 -4) 📝 `ct/apache-couchdb.sh` (+0 -4) 📝 `ct/apache-guacamole.sh` (+0 -4) 📝 `ct/apache-tika.sh` (+0 -4) 📝 `ct/apt-cacher-ng.sh` (+0 -4) 📝 `ct/archivebox.sh` (+0 -4) _...and 80 more files_ </details> ### 📄 Description ## ✍️ Description - remove base_settings (already declared in build.func) - remove unneeded comments - remove unneeded empty lines ## 🔗 Related PR / Discussion / Issue - generel cleanup ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change - [x] ✨ **New feature** – Adds new, non-breaking functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:05:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?