[PR #2377] [MERGED] [gh] Rework error Reporting in app-test workflow #3630

New Issue

saavagebueno · 2025-11-20T06:05:54-05:00

saavagebueno commented

2025-11-20 06:05:54 -05:00

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2377
Author: @michelroegl-brunner
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/13/2025
Merged by: @michelroegl-brunner

Base: main ← Head: workflow_michel

📝 Commits (1)

6806d62 Rework error handeling

📊 Changes

2 files changed (+23 additions, -20 deletions)

View changed files

📝 .github/workflows/scripts/app-test/pr-build.func (+1 -1)
📝 .github/workflows/scripts/app-test/pr-install.func (+22 -19)

📄 Description

✍️ Description

This PR reworks the error Reporting to make use of $STD but dont lose the wanted information. So pip, npm etc. warnings will no longer be commented.

Link: #

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

Self-review performed – Code follows established patterns and conventions.
Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

🐞 Bug fix – Resolves an issue without breaking functionality.
[] ✨ New feature – Adds new, non-breaking functionality.
[] 💥 Breaking change – Alters existing functionality in a way that may require updates.
[] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2377 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `workflow_michel` --- ### 📝 Commits (1) - [`6806d62`](https://github.com/community-scripts/ProxmoxVE/commit/6806d62132a5b1e470f070d348b3bd32262088b5) Rework error handeling ### 📊 Changes **2 files changed** (+23 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/scripts/app-test/pr-build.func` (+1 -1) 📝 `.github/workflows/scripts/app-test/pr-install.func` (+22 -19) </details> ### 📄 Description ## ✍️ Description  This PR reworks the error Reporting to make use of $STD but dont lose the wanted information. So pip, npm etc. warnings will no longer be commented. ## 🔗 Related PR / Discussion / Issue Link: # ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [X] **Self-review performed** – Code follows established patterns and conventions. - [X] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional)  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 06:05:54 -05:00

saavagebueno closed this issue

2025-11-20 06:05:54 -05:00

saavagebueno referenced this issue

2025-11-20 06:10:02 -05:00

[PR #3633] [MERGED] slskd: fix typo for config note #4440

saavagebueno referenced this issue

2025-11-20 06:10:03 -05:00

[PR #3633] slskd: fix typo for config note #4443

Sign in to join this conversation.