SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-28 00:32:47 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2400] Script Format Check Workflow #3649

New Issue
Closed
opened 2025-11-20 06:05:59 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:05:59 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/2400

State: closed
Merged: Yes

✍️ Description

This introduces a new Shell Format check to see if a few set standard lines are what we expect. If there are errors ther will be a comment with the offending Line and what should be there.

ADVISE: THIS WILL TRIGGER ON MANY SCRIPTS AT THE MOMENT
We as contributors would have to fix wrong formatted scripts either befor merge of this or when a PR with a Script comes up. This will be anyoing for a few weeks until the standards are met.

In theory we could just sed through the script and correct offending lines automaticaly, but i´m not sure if we really want that.

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • [] 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

image

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/2400 **State:** closed **Merged:** Yes --- ## ✍️ Description <!-- Provide a clear and concise description of your changes. --> This introduces a new Shell Format check to see if a few set standard lines are what we expect. If there are errors ther will be a comment with the offending Line and what should be there. __**ADVISE: THIS WILL TRIGGER ON MANY SCRIPTS AT THE MOMENT**__ We as contributors would have to fix wrong formatted scripts either befor merge of this or when a PR with a Script comes up. This will be anyoing for a few weeks until the standards are met. In theory we could just sed through the script and correct offending lines automaticaly, but i´m not sure if we really want that. ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [X] **Self-review performed** – Code follows established patterns and conventions. - [X] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [X] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) <!-- Provide extra context, screenshots, or references if needed. --> ![image](https://github.com/user-attachments/assets/6ef32aaf-0496-463d-99a5-3f2447c955dc)
saavagebueno added the pull-request label 2025-11-20 06:05:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3649
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?