SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2428] [MERGED] Fix: Grist update no longer removes previous user data #3665

New Issue
Open
opened 2025-11-20 06:06:04 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:06:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2428
Author: @cfurrow
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @MickLesk

Base: main ← Head: 2421-grist-update-deletes-user-data

📝 Commits (2)

  • 10e3f8c fix: copy previous user files from /opt/grist_bak
  • 0906890 chore: add more logging when running update scripts

📊 Changes

1 file changed (+19 additions, -1 deletions)

View changed files

📝 ct/grist.sh (+19 -1)

📄 Description

✍️ Description

Fixed the update script to copy known grist user files from the /opt/grist_bak directory to the newly installed /opt/grist directory. Thanks to @wms8688 for reporting the issue.

Known user files:

  • docs/ folder, which contains *.grist files
  • grist-sessions.db
  • landing.db

🔗 Related PR / Discussion / Issue

Issue: #2421
PR that introduced Grist community script: #1076

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2428 **Author:** [@cfurrow](https://github.com/cfurrow) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `2421-grist-update-deletes-user-data` --- ### 📝 Commits (2) - [`10e3f8c`](https://github.com/community-scripts/ProxmoxVE/commit/10e3f8c3a3433e0b56524b08dd82be15477c2732) fix: copy previous user files from /opt/grist_bak - [`0906890`](https://github.com/community-scripts/ProxmoxVE/commit/090689041234e99e1a2b1e0820e04008ea1b8e58) chore: add more logging when running update scripts ### 📊 Changes **1 file changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ct/grist.sh` (+19 -1) </details> ### 📄 Description ## ✍️ Description Fixed the update script to copy known grist user files from the `/opt/grist_bak` directory to the newly installed `/opt/grist` directory. Thanks to @wms8688 for reporting the issue. Known user files: - `docs/` folder, which contains `*.grist` files - `grist-sessions.db` - `landing.db` ## 🔗 Related PR / Discussion / Issue Issue: #2421 PR that introduced Grist community script: #1076 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:06:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?