SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2476] [MERGED] Fix: SQL Server 2022 | GPG & Install #3686

New Issue
Closed
opened 2025-11-20 06:06:10 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:06:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2476
Author: @MickLesk
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @michelroegl-brunner

Base: main ← Head: MickLesk-patch-2

📝 Commits (1)

  • 1aac334 Fix: SQL Server 2022 | GPG & Install

📊 Changes

1 file changed (+12 additions, -16 deletions)

View changed files

📝 install/sqlserver2022-install.sh (+12 -16)

📄 Description

✍️ Description

final fix for mssql server installation without gpg bricks
install in verbose and silent mode work fine.

#2401

image

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2476 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `MickLesk-patch-2` --- ### 📝 Commits (1) - [`1aac334`](https://github.com/community-scripts/ProxmoxVE/commit/1aac3347156dfbb42eff9d8d53da71772fefb604) Fix: SQL Server 2022 | GPG & Install ### 📊 Changes **1 file changed** (+12 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `install/sqlserver2022-install.sh` (+12 -16) </details> ### 📄 Description ## ✍️ Description final fix for mssql server installation without gpg bricks install in verbose and silent mode work fine. #2401 ![image](https://github.com/user-attachments/assets/cbde5180-40bd-48da-b397-3a3135a081c9) ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:06:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?