SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #2479] Fix: PATH env and file handling in Watcharr Update Script #3689

New Issue
Closed
opened 2025-11-20 06:06:11 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:06:11 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/2479

State: closed
Merged: No

✍️ Description

I've found and fixed two small bugs inside the Watcharr update function.

  1. golang binary was in /urs/local/bin, which wasn't present in PATH environment -> see #2478
  2. command to replace new files over old files did not work

🔗 Related PR / Discussion / Issue

Fixes #2478

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] ✨ New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

Screenshot 2025-02-18 200205

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/2479 **State:** closed **Merged:** No --- ## ✍️ Description I've found and fixed two small bugs inside the Watcharr update function. 1. golang binary was in /urs/local/bin, which wasn't present in PATH environment -> see #2478 2. command to replace new files over old files did not work ## 🔗 Related PR / Discussion / Issue Fixes #2478 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) ![Screenshot 2025-02-18 200205](https://github.com/user-attachments/assets/0d26b776-f952-4996-b7b9-2765f54bedd8)
saavagebueno added the pull-request label 2025-11-20 06:06:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?