[PR #2534] [MERGED] Fix: Update-Script Firefly III based on their docs #3718

Closed
opened 2025-11-20 06:06:21 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2534
Author: @MickLesk
Created: 2/21/2025
Status: Merged
Merged: 2/24/2025
Merged by: @tremor021

Base: mainHead: MickLesk-patch-2


📝 Commits (6)

  • bc1da77 Fix: Update-Script Firefly III Based on there docs
  • 62229fa Update autolabeler.yml
  • 5fe95d3 Update autolabeler.yml
  • 0a8e370 Update firefly.sh
  • e4c7d70 Update firefly.sh
  • 347573d Merge conflict resolved in firefly.sh

📊 Changes

1 file changed (+7 additions, -9 deletions)

View changed files

📝 ct/firefly.sh (+7 -9)

📄 Description

✍️ Description

Firefly III changed there Docs 2 days ago.

Some Commands are removed and renamed

Link: #2533
https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/

Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2534 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `MickLesk-patch-2` --- ### 📝 Commits (6) - [`bc1da77`](https://github.com/community-scripts/ProxmoxVE/commit/bc1da77c734bcee0f17d4a6b99b2bf45e71b64af) Fix: Update-Script Firefly III Based on there docs - [`62229fa`](https://github.com/community-scripts/ProxmoxVE/commit/62229fa9aaca791485e3cb774063bd494b61946f) Update autolabeler.yml - [`5fe95d3`](https://github.com/community-scripts/ProxmoxVE/commit/5fe95d3dc98b670cb902127fcfb8f7a53b09f494) Update autolabeler.yml - [`0a8e370`](https://github.com/community-scripts/ProxmoxVE/commit/0a8e370e17230ba58e4c303be856ccd83d4082bb) Update firefly.sh - [`e4c7d70`](https://github.com/community-scripts/ProxmoxVE/commit/e4c7d707d6f4de492ea89b106bde82c3ce53d0b0) Update firefly.sh - [`347573d`](https://github.com/community-scripts/ProxmoxVE/commit/347573d162ffa850561e32219fc046ad9bd00818) Merge conflict resolved in firefly.sh ### 📊 Changes **1 file changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `ct/firefly.sh` (+7 -9) </details> ### 📄 Description ## ✍️ Description Firefly III changed there Docs 2 days ago. Some Commands are removed and renamed ## 🔗 Related PR / Discussion / Issue Link: #2533 https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/ ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) <!-- Provide extra context, screenshots, or references if needed. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:06:21 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#3718