Actual Budget Update Failing #404

@infinitytec commented on GitHub (Jan 23, 2025):

Same issue here. I was coming across this in #1623 which got closed without full resolution.

@infinitytec commented on GitHub (Jan 23, 2025): Same issue here. I was coming across this in #1623 which got closed without full resolution.

saavagebueno commented

@chmsant commented on GitHub (Jan 23, 2025):

Looks like some of the codebase has been playing leapfrog.

Commit 5c1954c added the following on line 41

mv actualbudget-actual-server-*/* /opt/actualbudget/

Then in commit dd0cdf5 it became:
mv actual-server-* /opt/actualbudget
on line 54

there's an extra "/*" missing from the folder path from the latest commits?

EDIT: Tried forking and messing around with it and doesn't seem to have fixed. Lost again.

@chmsant commented on GitHub (Jan 23, 2025): Looks like some of the codebase has been playing leapfrog. Commit [5c1954c](https://github.com/community-scripts/ProxmoxVE/commit/5c1954c85d15230b8d03634423e1083208b448c1) added the following on line 41 ` mv actualbudget-actual-server-*/* /opt/actualbudget/` Then in commit [dd0cdf5](https://github.com/community-scripts/ProxmoxVE/commit/dd0cdf5d2575cc12ffdb9e9418c23ed6f255de35) it became: ` mv actual-server-* /opt/actualbudget` on line 54 there's an extra "/*" missing from the folder path from the latest commits? EDIT: Tried forking and messing around with it and doesn't seem to have fixed. Lost again.

saavagebueno commented

@MickLesk commented on GitHub (Jan 24, 2025):

The biggest problem with this script is the Git retrieval. I worked on it for 2 days, at most 1 of 10 calls worked.
I can then look again to see if there is anything left, but in the end it worked several times for me.

I have already considered removing it, as it only causes problems and they maintain their projects in a very peculiar way.

@MickLesk commented on GitHub (Jan 24, 2025): The biggest problem with this script is the Git retrieval. I worked on it for 2 days, at most 1 of 10 calls worked. I can then look again to see if there is anything left, but in the end it worked several times for me. I have already considered removing it, as it only causes problems and they maintain their projects in a very peculiar way.

saavagebueno commented

@MickLesk commented on GitHub (Jan 24, 2025):

i found an little bug in the curl and jq dep in update function, i fixed it.

Checkout following guide:

1. Set a specific version (not the current one)

Run the following command to set a specific version, e.g., v24.12.0:

echo "v24.12.0" > /opt/actualbudget_version.txt

2. Perform the update

Execute the update process on your LXC after setting the version.

3. Provide feedback

Once the update is complete, please test the changes and share your feedback.

Otherwise: Create an new LXC

@MickLesk commented on GitHub (Jan 24, 2025): i found an little bug in the curl and jq dep in update function, i fixed it. Checkout following guide: ## 1. Set a specific version (not the current one) Run the following command to set a specific version, e.g., `v24.12.0`: ```bash echo "v24.12.0" > /opt/actualbudget_version.txt ``` ## 2. Perform the update Execute the update process on your LXC after setting the version. ## 3. Provide feedback Once the update is complete, please test the changes and share your feedback. Otherwise: Create an new LXC

saavagebueno commented

@infinitytec commented on GitHub (Jan 24, 2025):

Thanks, I'll try that later today.

@infinitytec commented on GitHub (Jan 24, 2025): Thanks, I'll try that later today.

saavagebueno commented

@chmsant commented on GitHub (Jan 24, 2025):

@MickLesk followed your instructions both in existing LXC and new LXC. While the mv issue seems to be fixed in the new LXC, I'm now seeing the following error:

[ERROR] in line 53: exit code 0: while executing command yarn install &> /dev/null

which seems to be what @infinitytec was seeing in #1623

@chmsant commented on GitHub (Jan 24, 2025): @MickLesk followed your instructions both in existing LXC and new LXC. While the mv issue seems to be fixed in the new LXC, I'm now seeing the following error: `[ERROR] in line 53: exit code 0: while executing command yarn install &> /dev/null` which seems to be what @infinitytec was seeing in [#1623](https://github.com/community-scripts/ProxmoxVE/issues/1623)

saavagebueno commented

@MickLesk commented on GitHub (Jan 24, 2025):

Can you create an new one? The shit script has a lot of build bugs after Update

@MickLesk commented on GitHub (Jan 24, 2025): Can you create an new one? The shit script has a lot of build bugs after Update

saavagebueno commented

@chmsant commented on GitHub (Jan 24, 2025):

My apologies, I should have clarified my terminology. "Existing LXC" is now the one I created last week. "New LXC" was instantiated a few hours ago after your response earlier today, and after your latest commit.

@chmsant commented on GitHub (Jan 24, 2025): My apologies, I should have clarified my terminology. "Existing LXC" is now the one I created last week. "New LXC" was instantiated a few hours ago after your response earlier today, and after your latest commit.

saavagebueno commented

@MickLesk commented on GitHub (Jan 24, 2025):

on an new lxc you get an yarn install issue? wtf, im not. ActualBudget Script is fck annoying

@MickLesk commented on GitHub (Jan 24, 2025): on an new lxc you get an yarn install issue? wtf, im not. ActualBudget Script is fck annoying

saavagebueno commented

@chmsant commented on GitHub (Jan 24, 2025):

Yep. When I then try to do the corepack update to solve the yarn install issue, as suggested on infinitytec's issue report, I now get a different move error:

mv cannot stat '/opt/actualbudget_bak/.env': no such file or directory
[ERROR] in line 50: exit code 0: while executing command mv /opt/actualbudget_bak.env /opt/actualbudget

Might I request the issue be re-opened to increase visibility so that other devs/users can take a look?

@chmsant commented on GitHub (Jan 24, 2025): Yep. When I then try to do the corepack update to solve the yarn install issue, as suggested on infinitytec's issue report, I now get a different move error: ``` mv cannot stat '/opt/actualbudget_bak/.env': no such file or directory [ERROR] in line 50: exit code 0: while executing command mv /opt/actualbudget_bak.env /opt/actualbudget ``` Might I request the issue be re-opened to increase visibility so that other devs/users can take a look?

saavagebueno commented

@devdecrux commented on GitHub (Jan 24, 2025):

I get the following error when executing update or executing the script:

⠇mv: cannot move '/opt/actualbudget' to '/opt/actualbudget_bak/actualbudget': Directory not empty [ERROR] in line 46: exit code 0: while executing command mv /opt/actualbudget /opt/actualbudget_bak

@devdecrux commented on GitHub (Jan 24, 2025): I get the following error when executing `update` or executing the script: `⠇mv: cannot move '/opt/actualbudget' to '/opt/actualbudget_bak/actualbudget': Directory not empty [ERROR] in line 46: exit code 0: while executing command mv /opt/actualbudget /opt/actualbudget_bak`

saavagebueno commented

@infinitytec commented on GitHub (Jan 24, 2025):

Yep. When I then try to do the corepack update to solve the yarn install issue, as suggested on infinitytec's issue report, I now get a different move error:
mv cannot stat '/opt/actualbudget_bak/.env': no such file or directory
[ERROR] in line 50: exit code 0: while executing command mv /opt/actualbudget_bak.env /opt/actualbudget
Might I request the issue be re-opened to increase visibility so that other devs/users can take a look?

@MickLesk can we get this issue re-opened?

@infinitytec commented on GitHub (Jan 24, 2025): > Yep. When I then try to do the corepack update to solve the yarn install issue, as suggested on infinitytec's issue report, I now get a different move error: > > ``` > mv cannot stat '/opt/actualbudget_bak/.env': no such file or directory > [ERROR] in line 50: exit code 0: while executing command mv /opt/actualbudget_bak.env /opt/actualbudget > ``` > > Might I request the issue be re-opened to increase visibility so that other devs/users can take a look? @MickLesk can we get this issue re-opened?

saavagebueno commented

@infinitytec commented on GitHub (Jan 25, 2025):

I have an almost working solution!

Of course, make a backup first. This is also really a breaking change because it changes the path the application runs out of.

This also breaks the application starting at boot (probably due to systemctl and the path change)!

systemctl stop actualbudget
apt update && apt upgrade -y
npm install -g npm
mv /opt/actualbudget /opt/actualbudget_bak
cd /opt
git clone https://github.com/actualbudget/actual-server.git
cd /opt/actual-server
corepack enable
corepack prepare yarn@4.3.1 --activate
yarn add @babel/core -D
yarn add typescript -D
yarn add ipaddr.js
yarn add proxy-addr
yarn add axios
yarn rebuild
npm rebuild bcrypt
npm rebuild better-sqlite3
yarn install
yarn start

The application should start. Now, ctrl+c to close it, then run the following to copy your data:

mv /opt/actualbudget_bak/server-files/* /opt/actual-server/server-files
mv /opt/actualbudget_bak/user-files/* /opt/actual-server/user-files
yarn start

The application should start and your data should be intact.

If you copy the data before running the application once it gives and SQL error.

This melted my brain.

Now if someone can get this to work seamlessly and update the main script, that would be awesome. For now, I'm just going to run the old version until this gets figured out.

@infinitytec commented on GitHub (Jan 25, 2025): I have an almost working solution! Of course, make a backup first. This is also really a breaking change because it changes the path the application runs out of. This also breaks the application starting at boot (probably due to systemctl and the path change)! ``` systemctl stop actualbudget apt update && apt upgrade -y npm install -g npm mv /opt/actualbudget /opt/actualbudget_bak cd /opt git clone https://github.com/actualbudget/actual-server.git cd /opt/actual-server corepack enable corepack prepare yarn@4.3.1 --activate yarn add @babel/core -D yarn add typescript -D yarn add ipaddr.js yarn add proxy-addr yarn add axios yarn rebuild npm rebuild bcrypt npm rebuild better-sqlite3 yarn install yarn start ``` The application should start. Now, ctrl+c to close it, then run the following to copy your data: ``` mv /opt/actualbudget_bak/server-files/* /opt/actual-server/server-files mv /opt/actualbudget_bak/user-files/* /opt/actual-server/user-files yarn start ``` The application should start and your data should be intact. If you copy the data before running the application once it gives and SQL error. This melted my brain. Now if someone can get this to work seamlessly and update the main script, that would be awesome. For now, I'm just going to run the old version until this gets figured out.

saavagebueno commented

@MickLesk commented on GitHub (Jan 25, 2025):

We dont use git clone and add unnessecarry deps like babel, this should be done by the maintainer of actual Budget. Ive checked the Changelog and there are not Breaking changes declared, sad for everyone.

I take a look next week

@MickLesk commented on GitHub (Jan 25, 2025): We dont use git clone and add unnessecarry deps like babel, this should be done by the maintainer of actual Budget. Ive checked the Changelog and there are not Breaking changes declared, sad for everyone. I take a look next week

saavagebueno commented

@infinitytec commented on GitHub (Jan 25, 2025):

We dont use git clone and add unnessecarry deps like babel, this should be done by the maintainer of actual Budget. Ive checked the Changelog and there are not Breaking changes declared, sad for everyone.

I take a look next week

You are correct.

My first script can be simplified to this:

systemctl stop actualbudget
apt update && apt upgrade -y
npm install -g npm
mv /opt/actualbudget /opt/actualbudget_bak
cd /opt
git clone https://github.com/actualbudget/actual-server.git
cd /opt/actual-server
yarn install
yarn start

@infinitytec commented on GitHub (Jan 25, 2025): > We dont use git clone and add unnessecarry deps like babel, this should be done by the maintainer of actual Budget. Ive checked the Changelog and there are not Breaking changes declared, sad for everyone. > > I take a look next week You are correct. My first script can be simplified to this: ``` systemctl stop actualbudget apt update && apt upgrade -y npm install -g npm mv /opt/actualbudget /opt/actualbudget_bak cd /opt git clone https://github.com/actualbudget/actual-server.git cd /opt/actual-server yarn install yarn start ```

saavagebueno commented

@maciejmatczak commented on GitHub (Jan 26, 2025):

Hey all, taking a look on execution on these as well. I was executing steps from update script manually, starting from fresh install.

Fresh install seems to work properly and picks up yarn/4.3.1:

  ✔️  Installed Node.js
 ⠏➤ YN0065: Yarn will periodically gather anonymous telemetry: https://yarnpkg.com/advanced/telemetry
➤ YN0065: Run yarn config set --home enableTelemetry 0 to disable

 ⠋➤ YN0000: · Yarn 4.3.1
➤ YN0000: ┌ Resolution step
 ⠹➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
➤ YN0002: │ actual-sync@workspace:. doesn't provide @babel/core (p89c81), requested by @babel/preset-typescript.
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
 ⠙➤ YN0013: │ 660 packages were added to the project (+ 239.91 MiB).
➤ YN0000: └ Completed in 8s 154ms
➤ YN0000: ┌ Link step
 ⠧➤ YN0007: │ bcrypt@npm:5.1.1 must be built because it never has been before or the last one failed
➤ YN0007: │ better-sqlite3@npm:11.7.0 must be built because it never has been before or the last one failed
 ⠏➤ YN0000: └ Completed in 4s 924ms
 ⠋➤ YN0000: · Done with warnings in 13s 376ms

Trying to update todays fresh install, I see:

error This project's package.json defines "packageManager": "yarn@4.3.1". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.

1.22.2, hmm. Just after installation:

root@actualbudget:~# cd 
root@actualbudget:~# yarn --version
1.22.22
root@actualbudget:~# cd /opt/actualbudget
root@actualbudget:/opt/actualbudget# yarn --version
4.3.1

Oh cool, it's directory dependent. I did the update dance till yarn install (https://github.com/community-scripts/ProxmoxVE/blob/main/ct/actualbudget.sh#L54).

# note: this is new wget copy of actual
root@actualbudget:/tmp#         cd /opt/actualbudget
root@actualbudget:/opt/actualbudget# yarn --version
1.22.22

Guess what's yarn version when I jump back to _back:

# note: this is our old installation
root@actualbudget:/tmp#         cd /opt/actualbudget_bak
root@actualbudget:/opt/actualbudget# yarn --version
4.3.1

@maciejmatczak commented on GitHub (Jan 26, 2025): Hey all, taking a look on execution on these as well. I was executing steps from update script manually, starting from fresh install. Fresh install seems to work properly and picks up `yarn/4.3.1`: ``` ✔️ Installed Node.js ⠏➤ YN0065: Yarn will periodically gather anonymous telemetry: https://yarnpkg.com/advanced/telemetry ➤ YN0065: Run yarn config set --home enableTelemetry 0 to disable ⠋➤ YN0000: · Yarn 4.3.1 ➤ YN0000: ┌ Resolution step ⠹➤ YN0000: └ Completed ➤ YN0000: ┌ Post-resolution validation ➤ YN0002: │ actual-sync@workspace:. doesn't provide @babel/core (p89c81), requested by @babel/preset-typescript. ➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code. ➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details. ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ⠙➤ YN0013: │ 660 packages were added to the project (+ 239.91 MiB). ➤ YN0000: └ Completed in 8s 154ms ➤ YN0000: ┌ Link step ⠧➤ YN0007: │ bcrypt@npm:5.1.1 must be built because it never has been before or the last one failed ➤ YN0007: │ better-sqlite3@npm:11.7.0 must be built because it never has been before or the last one failed ⠏➤ YN0000: └ Completed in 4s 924ms ⠋➤ YN0000: · Done with warnings in 13s 376ms ``` Trying to update todays fresh install, I see: ``` error This project's package.json defines "packageManager": "yarn@4.3.1". However the current global version of Yarn is 1.22.22. Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19. Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack. ``` 1.22.2, hmm. Just after installation: ```shell root@actualbudget:~# cd root@actualbudget:~# yarn --version 1.22.22 root@actualbudget:~# cd /opt/actualbudget root@actualbudget:/opt/actualbudget# yarn --version 4.3.1 ``` Oh cool, it's directory dependent. I did the update dance till `yarn install` (https://github.com/community-scripts/ProxmoxVE/blob/main/ct/actualbudget.sh#L54). ```shell # note: this is new wget copy of actual root@actualbudget:/tmp# cd /opt/actualbudget root@actualbudget:/opt/actualbudget# yarn --version 1.22.22 ``` Guess what's yarn version when I jump back to _back: ```shell # note: this is our old installation root@actualbudget:/tmp# cd /opt/actualbudget_bak root@actualbudget:/opt/actualbudget# yarn --version 4.3.1 ```

saavagebueno commented

@maciejmatczak commented on GitHub (Jan 26, 2025):

@chmsant (https://github.com/community-scripts/ProxmoxVE/issues/1707#issuecomment-2611469042), this seems to be on point.

Install script does mv *ctual-server-* /opt/actualbudget, update script does mv *ctual-server-*/* /opt/actualbudget.

The later didn't move dot-files:

root@actualbudget:~# ls -la /tmp/actual-server-25.1.0/
total 64
drwxrwxr-x  4 root root  4096 Jan 26 20:24 .
drwxrwxrwt 11 root root 20480 Jan 26 20:24 ..
-rw-rw-r--  1 root root   134 Jan  7 07:36 .dockerignore
-rw-rw-r--  1 root root   175 Jan  7 07:36 .editorconfig
-rw-rw-r--  1 root root    57 Jan  7 07:36 .eslintignore
-rw-rw-r--  1 root root   438 Jan  7 07:36 .eslintrc.cjs
drwxrwxr-x  4 root root  4096 Jan  7 07:36 .github
-rw-rw-r--  1 root root   340 Jan  7 07:36 .gitignore
-rw-rw-r--  1 root root     8 Jan  7 07:36 .node-version
-rw-rw-r--  1 root root    52 Jan  7 07:36 .prettierrc.json
drwxrwxr-x  3 root root  4096 Jan  7 07:36 .yarn
-rw-rw-r--  1 root root    66 Jan  7 07:36 .yarnrc.yml

Did we hit bash and glob not hitting hidden files? Adding shopt -s dotglob:

root@actualbudget:/tmp# shopt -s dotglob 
root@actualbudget:/tmp# mv *ctual-server-*/* /opt/actualbudget
root@actualbudget:/tmp# ls -la actual-server-25.1.0/
total 24
drwxrwxr-x  2 root root  4096 Jan 26 20:44 .
drwxrwxrwt 11 root root 20480 Jan 26 20:24 ..

Installing:

root@actualbudget:/tmp# cd /opt/actualbudget
root@actualbudget:/opt/actualbudget# yarn install &>/dev/null
root@actualbudget:/opt/actualbudget# echo $?
0

@maciejmatczak commented on GitHub (Jan 26, 2025): @chmsant (https://github.com/community-scripts/ProxmoxVE/issues/1707#issuecomment-2611469042), this seems to be on point. Install script does `mv *ctual-server-* /opt/actualbudget`, update script does `mv *ctual-server-*/* /opt/actualbudget`. The later didn't move dot-files: ```shell root@actualbudget:~# ls -la /tmp/actual-server-25.1.0/ total 64 drwxrwxr-x 4 root root 4096 Jan 26 20:24 . drwxrwxrwt 11 root root 20480 Jan 26 20:24 .. -rw-rw-r-- 1 root root 134 Jan 7 07:36 .dockerignore -rw-rw-r-- 1 root root 175 Jan 7 07:36 .editorconfig -rw-rw-r-- 1 root root 57 Jan 7 07:36 .eslintignore -rw-rw-r-- 1 root root 438 Jan 7 07:36 .eslintrc.cjs drwxrwxr-x 4 root root 4096 Jan 7 07:36 .github -rw-rw-r-- 1 root root 340 Jan 7 07:36 .gitignore -rw-rw-r-- 1 root root 8 Jan 7 07:36 .node-version -rw-rw-r-- 1 root root 52 Jan 7 07:36 .prettierrc.json drwxrwxr-x 3 root root 4096 Jan 7 07:36 .yarn -rw-rw-r-- 1 root root 66 Jan 7 07:36 .yarnrc.yml ``` Did we hit bash and glob not hitting hidden files? Adding `shopt -s dotglob`: ```shell root@actualbudget:/tmp# shopt -s dotglob root@actualbudget:/tmp# mv *ctual-server-*/* /opt/actualbudget root@actualbudget:/tmp# ls -la actual-server-25.1.0/ total 24 drwxrwxr-x 2 root root 4096 Jan 26 20:44 . drwxrwxrwt 11 root root 20480 Jan 26 20:24 .. ``` Installing: ```shell root@actualbudget:/tmp# cd /opt/actualbudget root@actualbudget:/opt/actualbudget# yarn install &>/dev/null root@actualbudget:/opt/actualbudget# echo $? 0 ```

saavagebueno commented

@romdim commented on GitHub (Feb 13, 2025):

Btw, this happened 3 days ago, not sure yet if it affects the whole setup.

@romdim commented on GitHub (Feb 13, 2025): Btw, [this](https://actualbudget.org/docs/actual-server-repo-move/) happened 3 days ago, not sure yet if it affects the whole setup.

saavagebueno commented

@infinitytec commented on GitHub (Feb 13, 2025):

I was able to upgrade without issue yesterday.

@infinitytec commented on GitHub (Feb 13, 2025): I was able to upgrade without issue yesterday.

saavagebueno commented

@romdim commented on GitHub (Feb 13, 2025):

I still get the:

 ⠴mv: cannot stat '/opt/actualbudget_bak/.env': No such file or directory
 ⠦
[ERROR] in line 45: exit code 0: while executing command mv /opt/actualbudget_bak/.env /opt/actualbudget

when I try to update from 25.1.0 to the latest version.

@romdim commented on GitHub (Feb 13, 2025): I still get the: ``` ⠴mv: cannot stat '/opt/actualbudget_bak/.env': No such file or directory ⠦ [ERROR] in line 45: exit code 0: while executing command mv /opt/actualbudget_bak/.env /opt/actualbudget ``` when I try to update from 25.1.0 to the latest version.

saavagebueno commented