[PR #3132] [MERGED] ByteStash: Add option for multiple accounts and generate JWT secret #4093

Closed
opened 2025-11-20 06:08:16 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3132
Author: @tremor021
Created: 3/16/2025
Status: Merged
Merged: 3/17/2025
Merged by: @michelroegl-brunner

Base: mainHead: bytestash


📝 Commits (1)

  • 28bd1cd Add option for multiple accounts and generate JWT secret

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 install/bytestash-install.sh (+10 -0)

📄 Description

✍️ Description

This PR adds option to keep registrations open after initial account creation. This is meant if multiple users plan on using the same server. We also generate JWT secret just in case.

Link: #3128

Prerequisites

Before this PR can be reviewed, the following must be completed:

  • [] Self-review performed – Code follows established patterns and conventions.
  • [] Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • [] 🆕 New script – A fully functional and tested script or script set.
  • [] 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3132 **Author:** [@tremor021](https://github.com/tremor021) **Created:** 3/16/2025 **Status:** ✅ Merged **Merged:** 3/17/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `bytestash` --- ### 📝 Commits (1) - [`28bd1cd`](https://github.com/community-scripts/ProxmoxVE/commit/28bd1cd064c8b93667cc75b1d4a1f3568690a234) Add option for multiple accounts and generate JWT secret ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `install/bytestash-install.sh` (+10 -0) </details> ### 📄 Description ## ✍️ Description This PR adds option to keep registrations open after initial account creation. This is meant if multiple users plan on using the same server. We also generate JWT secret just in case. ## 🔗 Related PR / Discussion / Issue Link: #3128 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [] **Self-review performed** – Code follows established patterns and conventions. - [] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [] 🆕 **New script** – A fully functional and tested script or script set. - [] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [✅] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. ## 📋 Additional Information (optional) <!-- Provide extra context, screenshots, or references if needed. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:08:16 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#4093