SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #3158] [CLOSED] Trilium: Name of directory inside of the downloaded tar changed #4111

New Issue
Closed
opened 2025-11-20 06:08:22 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:08:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3158
Author: @Scorpoon
Created: 3/17/2025
Status: ❌ Closed

Base: main ← Head: Trilium-Fix-Env_Variable

📝 Commits (3)

  • 289560a Fix wrong usage of environment variable
  • bfe258c Directory name inside of .tar.xz file changed
  • 3acdac3 Update trilium-install.sh

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 ct/trilium.sh (+2 -1)
📝 install/trilium-install.sh (+2 -1)

📄 Description

✍️ Description

The directory name changed inside of the downloaded tar file, before the folder had the version number with a "v" in front of it, now it's only the number without a "v".

I've tested the change locally by copy pasting the commands into my shell.

🔗 Related PR / Discussion / Issue

Link: #3151 & #3152

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🆕 New script – A fully functional and tested script or script set.
  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

📋 Additional Information (optional)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3158 **Author:** [@Scorpoon](https://github.com/Scorpoon) **Created:** 3/17/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Trilium-Fix-Env_Variable` --- ### 📝 Commits (3) - [`289560a`](https://github.com/community-scripts/ProxmoxVE/commit/289560a6c0e237e7c08132251322b9ad7851084f) Fix wrong usage of environment variable - [`bfe258c`](https://github.com/community-scripts/ProxmoxVE/commit/bfe258c360aa98ee1925f13597573469c62737cf) Directory name inside of .tar.xz file changed - [`3acdac3`](https://github.com/community-scripts/ProxmoxVE/commit/3acdac369b56d8091331e5430d8dc4ce8ce34745) Update trilium-install.sh ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ct/trilium.sh` (+2 -1) 📝 `install/trilium-install.sh` (+2 -1) </details> ### 📄 Description ## ✍️ Description The directory name changed inside of the downloaded tar file, before the folder had the version number with a "v" in front of it, now it's only the number without a "v". I've tested the change locally by copy pasting the commands into my shell. ## 🔗 Related PR / Discussion / Issue Link: #3151 & #3152 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [X] **Self-review performed** – Code follows established patterns and conventions. - [X] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. ## 📋 Additional Information (optional) <!-- Provide extra context, screenshots, or references if needed. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:08:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#4111
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?