SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-11 18:52:12 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #3270] [MERGED] FluidCalendar: Switch to safer DB operations #4197

New Issue
Closed
opened 2025-11-20 06:08:50 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:08:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3270
Author: @vhsdream
Created: 3/19/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fluidDBfix

📝 Commits (1)

  • afe523d FluidCalendar: Switch to safer DB operations

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 ct/fluid-calendar.sh (+1 -1)
📝 install/fluid-calendar-install.sh (+1 -1)

📄 Description

But really, take a snapshot/backup before updating!

✍️ Description

I've confirmed with the FluidCalendar dev that these commands are better for preventing data loss; although it's still possible in future to have migration errors occur, which is why it's always a good idea to take a snapshot/make a backup before updating.

🔗 Related PR / Issue

Link: #3254

Issue in the FluidCalendar repo

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)

While I have tested this change in as many ways as I can, and I can confirm that there is no data loss when updating with this change, I can't really say whether it will or won't introduce issues further down the road. So I suggest that people do a clean install rather than updating, if they already have installed via the previous install script.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3270 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fluidDBfix` --- ### 📝 Commits (1) - [`afe523d`](https://github.com/community-scripts/ProxmoxVE/commit/afe523d9269d64573cdd8a2a296e06cd8c8416f1) FluidCalendar: Switch to safer DB operations ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ct/fluid-calendar.sh` (+1 -1) 📝 `install/fluid-calendar-install.sh` (+1 -1) </details> ### 📄 Description But really, take a snapshot/backup before updating! <!--🛑 New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs for new scripts that skip this process will be closed. --> ## ✍️ Description I've confirmed with the FluidCalendar dev that these commands are better for preventing data loss; although it's still possible in future to have migration errors occur, which is why it's always a good idea to take a snapshot/make a backup before updating. ## 🔗 Related PR / Issue Link: #3254 Issue in the [FluidCalendar](https://github.com/dotnetfactory/fluid-calendar/issues/70) repo ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [x] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [x] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> While I have tested this change in as many ways as I can, and I can confirm that there is no data loss when updating with this change, I can't really say whether it will or won't introduce issues further down the road. So I suggest that people **do a clean install** rather than updating, if they already have installed via the previous install script. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:08:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#4197
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?