SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-11 08:32:22 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #3771] [MERGED] core: Removal of OS/Version Selection from Advanced Settings #4532

New Issue
Closed
opened 2025-11-20 06:10:28 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:10:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3771
Author: @MickLesk
Created: 4/9/2025
Status: ✅ Merged
Merged: 4/9/2025
Merged by: @tremor021

Base: main ← Head: remove_os_selection

📝 Commits (2)

  • 6ff26cc core: remove os selection in advanced_settings
  • 4f95257 debian/ubuntu vars

📊 Changes

3 files changed (+73 additions, -191 deletions)

View changed files

📝 ct/debian.sh (+19 -19)
📝 ct/ubuntu.sh (+19 -19)
📝 misc/build.func (+35 -153)

📄 Description

📦 Removal of OS/Version Selection from Advanced Settings

Following the results of Discussion #3300 and feedback from the community, we have decided to remove the OS/Version selection from the Advanced Settings UI.

🗳️ Poll Results

Should we keep the OS/Version selection in Advanced Settings?

  • ✅ Keep it: 32%
  • ❌ Remove it: 67%

The majority of users and contributors agreed that while custom OS selection can be useful, it causes too many unsupported issues, confusion, and inconsistent user experiences.

❌ What Changed?

The whiptail for OS and Version selection has been removed from the UI.
Scripts now only support their default OS and version, as defined by the maintainers.

This change:

  • Reduces user errors and invalid bug reports
  • Makes issue triaging easier and more predictable
  • Improves long-term maintainability of over 300+ scripts

🧠 What About Power Users?

Advanced users can still override the default values by passing environment variables to the script at runtime.
This method is unsupported, but remains available for experienced users who know what they’re doing.
Remark: Not all Scripts include this yet, there will be an new PR maybe this week.

📘 Using var_* Environment Variables

Scripts that support dynamic overrides (e.g. ct/debian.sh) accept the following var_* variables:

Variable Default Description
var_os debian Base OS (e.g. ubuntu)
var_version 12 OS version (e.g. 24.04)
var_cpu 1 Number of vCPUs
var_ram 512 RAM in MB
var_disk 2 Disk size in GB
var_tags os Container tag(s)
var_unprivileged 1 Use unprivileged container (1 = yes)

✅ Example Usage

🔹 Example 1: Debian 12, 2 CPUs, 1024 MB RAM, 8 GB Disk

var_cpu=2 var_ram=1024 var_disk=8 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

🔹 Example 2: Debian 11, privileged container

var_version=11 var_unprivileged=0 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

🔹 Example 3: Custom tags and CPU/RAM settings

var_tags="webserver" var_cpu=4 var_ram=2048 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

🔹 Example 4: Ubuntu 24.10, 2 core, 1024MB ram

var_os=ubuntu var_version=24.10 var_cpu=2 var_ram=1024 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3771 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `remove_os_selection` --- ### 📝 Commits (2) - [`6ff26cc`](https://github.com/community-scripts/ProxmoxVE/commit/6ff26cc216d8fa3b7cd7dab20c113c23ca7c81aa) core: remove os selection in advanced_settings - [`4f95257`](https://github.com/community-scripts/ProxmoxVE/commit/4f95257c5c6b5b58a9b175e12d697ee19854f005) debian/ubuntu vars ### 📊 Changes **3 files changed** (+73 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `ct/debian.sh` (+19 -19) 📝 `ct/ubuntu.sh` (+19 -19) 📝 `misc/build.func` (+35 -153) </details> ### 📄 Description # 📦 Removal of OS/Version Selection from Advanced Settings Following the results of [Discussion #3300](https://github.com/community-scripts/ProxmoxVE/discussions/3300) and feedback from the community, we have decided to **remove the OS/Version selection from the Advanced Settings UI**. --- ## 🗳️ Poll Results > **Should we keep the OS/Version selection in Advanced Settings?** - ✅ Keep it: **32%** - ❌ Remove it: **67%** The majority of users and contributors agreed that while custom OS selection can be useful, it causes too many unsupported issues, confusion, and inconsistent user experiences. --- ## ❌ What Changed? The whiptail for OS and Version selection has been removed from the UI. Scripts now only support their **default OS and version**, as defined by the maintainers. This change: - Reduces user errors and invalid bug reports - Makes issue triaging easier and more predictable - Improves long-term maintainability of over 300+ scripts --- ## 🧠 What About Power Users? Advanced users can still override the default values by passing environment variables to the script at runtime. This method is **unsupported**, but remains available for experienced users who know what they’re doing. Remark: Not all Scripts include this yet, there will be an new PR maybe this week. --- ### 📘 Using `var_*` Environment Variables Scripts that support dynamic overrides (e.g. `ct/debian.sh`) accept the following `var_*` variables: | Variable | Default | Description | |--------------------|-------------|-----------------------------------------| | `var_os` | `debian` | Base OS (e.g. `ubuntu`) | | `var_version` | `12` | OS version (e.g. `24.04`) | | `var_cpu` | `1` | Number of vCPUs | | `var_ram` | `512` | RAM in MB | | `var_disk` | `2` | Disk size in GB | | `var_tags` | `os` | Container tag(s) | | `var_unprivileged` | `1` | Use unprivileged container (1 = yes) | --- ## ✅ Example Usage ### 🔹 Example 1: Debian 12, 2 CPUs, 1024 MB RAM, 8 GB Disk ```bash var_cpu=2 var_ram=1024 var_disk=8 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)" ``` --- ### 🔹 Example 2: Debian 11, privileged container ```bash var_version=11 var_unprivileged=0 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)" ``` --- ### 🔹 Example 3: Custom tags and CPU/RAM settings ```bash var_tags="webserver" var_cpu=4 var_ram=2048 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)" ``` --- ### 🔹 Example 4: Ubuntu 24.10, 2 core, 1024MB ram ```bash var_os=ubuntu var_version=24.10 var_cpu=2 var_ram=1024 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)" ``` --- ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:10:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#4532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?