SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #3841] [CLOSED] Fix version check for build.func #4581

New Issue
Open
opened 2025-11-20 06:10:42 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:10:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3841
Author: @MonishKrishna2009
Created: 4/11/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

  • b9f5ba3 Fix version check for build.func

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 misc/build.func (+1 -1)

📄 Description

✍️ Description

Fixed a bug in the pve_check() function where the Proxmox VE Helper Script incorrectly reported newer versions (e.g., 8.4.0) as outdated. Updated the version check logic to properly handle numeric comparisons and ensure compatibility with Proxmox VE version 8.1 or later.

✅ Prerequisites (X in brackets)

  • [ X] Self-review completed – Code follows project standards.
  • [X ] Tested thoroughly – Changes work as expected.
  • [X ] No breaking changes – Existing functionality remains intact.
  • [X ] No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • [X ] 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • [ X] Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)

  • The issue was caused by incorrect version comparison logic in the pve_check() function, which relied on a regular expression that did not properly handle numeric comparisons for versions like 8.4.0.
  • The updated regex ensures compatibility with all Proxmox VE versions 8.1 and later, including patch versions and multi-digit minor versions (e.g., 8.10.0).
  • Thorough testing was performed on various Proxmox VE versions to confirm the fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3841 **Author:** [@MonishKrishna2009](https://github.com/MonishKrishna2009) **Created:** 4/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`b9f5ba3`](https://github.com/community-scripts/ProxmoxVE/commit/b9f5ba380d5383b1587c94a04120e108a479dff5) Fix version check for build.func ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+1 -1) </details> ### 📄 Description ## ✍️ Description Fixed a bug in the `pve_check()` function where the Proxmox VE Helper Script incorrectly reported newer versions (e.g., 8.4.0) as outdated. Updated the version check logic to properly handle numeric comparisons and ensure compatibility with Proxmox VE version 8.1 or later. ## ✅ Prerequisites (**X** in brackets) - [ X] **Self-review completed** – Code follows project standards. - [X ] **Tested thoroughly** – Changes work as expected. - [X ] **No breaking changes** – Existing functionality remains intact. - [X ] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ X] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> - The issue was caused by incorrect version comparison logic in the `pve_check()` function, which relied on a regular expression that did not properly handle numeric comparisons for versions like 8.4.0. - The updated regex ensures compatibility with all Proxmox VE versions 8.1 and later, including patch versions and multi-digit minor versions (e.g., 8.10.0). - Thorough testing was performed on various Proxmox VE versions to confirm the fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 06:10:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#4581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?