SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 14:23:53 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

checkmk (update) script ignores patch versions #503

New Issue
Closed
opened 2025-11-20 04:49:19 -05:00 by saavagebueno · 2 comments
saavagebueno commented 2025-11-20 04:49:19 -05:00
Owner
Copy Link

Originally created by @justusel on GitHub (Feb 10, 2025).

Originally assigned to: @michelroegl-brunner on GitHub.

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

checkmk

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/checkmk.sh)"

📝 Provide a clear and concise description of the issue.

Disclaimer:
The following issues were discovered while verifying the community-scripts because a current version (2.3.0) already seemed outdated after installation. The upgrade script was not run yet.

Problem:

The checkmk version is now stuck at 2.3.0 (4/29/2024) while the correct version seems to be 2.3.0p26 (2/4/2025). According repo-history this was introduced here:
https://github.com/community-scripts/ProxmoxVE/pull/1385/files

https://github.com/community-scripts/ProxmoxVE/pull/1341/files

I cannot really figure out why these changes where introduced because at least for the latest versions (and patches) the downloads seem as usual.
https://checkmk.com/download/archive
Maybe you can provide some details @michelroegl-brunner. Thanks in advance.

Results of version fetching in install/checkmk-install.sh:

root@test:~# RELEASE=$(curl -fsSL https://api.github.com/repos/checkmk/checkmk/tags | grep "name" | awk '{print substr($2, 3, length($2)-4) }' | head -n 1)
root@test:~# echo "https://download.checkmk.com/checkmk/${RELEASE}/check-mk-raw-${RELEASE}_0.bookworm_amd64.deb"
https://download.checkmk.com/checkmk/2.3.0/check-mk-raw-2.3.0_0.bookworm_amd64.deb

Also obverving these changed we see missing head -n 1 postprocessing within the ct/checkmk.sh.
Results of version fetching in cf/checkmk-install.sh:

root@test:~# RELEASE=$(curl -fsSL https://api.github.com/repos/checkmk/checkmk/tags | grep "name" | awk '{print substr($2, 3, length($2)-4) }')
root@test:~# echo "https://download.checkmk.com/checkmk/${RELEASE}/check-mk-raw-${RELEASE}_0.bookworm_amd64.deb"
https://download.checkmk.com/checkmk/2.3.0
2.3.0p26
2.3.0p26-rc1
2.3.0p25
2.3.0p25-rc1
2.3.0p24
2.3.0p24-rc1
2.3.0p23
2.3.0p23-rc1
2.3.0p22
2.3.0p22-rc1
2.3.0p21
2.3.0p21-rc2
2.3.0p21-rc1
2.3.0p20
2.3.0p20-rc2
2.3.0p20-rc1
2.3.0p19
2.3.0p19-rc2
2.3.0p19-rc1
2.3.0p18
2.3.0p18-rc3
2.3.0p18-rc2
2.3.0p18-rc1
2.3.0p17
2.3.0p17-rc3
2.3.0p17-rc2
2.3.0p17-rc1
2.3.0p16
2.3.0p16-rc1/check-mk-raw-2.3.0
2.3.0p26
2.3.0p26-rc1
2.3.0p25
2.3.0p25-rc1
2.3.0p24
2.3.0p24-rc1
2.3.0p23
2.3.0p23-rc1
2.3.0p22
2.3.0p22-rc1
2.3.0p21
2.3.0p21-rc2
2.3.0p21-rc1
2.3.0p20
2.3.0p20-rc2
2.3.0p20-rc1
2.3.0p19
2.3.0p19-rc2
2.3.0p19-rc1
2.3.0p18
2.3.0p18-rc3
2.3.0p18-rc2
2.3.0p18-rc1
2.3.0p17
2.3.0p17-rc3
2.3.0p17-rc2
2.3.0p17-rc1
2.3.0p16
2.3.0p16-rc1_0.bookworm_amd64.deb

This is probably also currently disabling the correct upgrade-precondition: "${RELEASE}" != "$(cat /opt/${APP}_version.txt)"

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

No response

🔄 Steps to reproduce the issue.

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/checkmk.sh)"

Observe:
$ cat /opt/checkmk_version.txt: 2.3.0

However expected is: 2.3.0p26

❌ Paste the full error output (if available).

.

🖼️ Additional context (optional).

No response

Originally created by @justusel on GitHub (Feb 10, 2025). Originally assigned to: @michelroegl-brunner on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? checkmk ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/checkmk.sh)" ### 📝 Provide a clear and concise description of the issue. Disclaimer: The following issues were discovered while verifying the community-scripts because a current version (2.3.0) already seemed outdated after installation. The upgrade script was not run yet. # Problem: The checkmk version is now stuck at `2.3.0` (4/29/2024) while the correct version seems to be `2.3.0p26` (2/4/2025). According repo-history this was introduced here: https://github.com/community-scripts/ProxmoxVE/pull/1385/files https://github.com/community-scripts/ProxmoxVE/pull/1341/files I cannot really figure out why these changes where introduced because at least for the latest versions (and patches) the downloads seem as usual. https://checkmk.com/download/archive Maybe you can provide some details @michelroegl-brunner. Thanks in advance. Results of version fetching in `install/checkmk-install.sh`: ``` root@test:~# RELEASE=$(curl -fsSL https://api.github.com/repos/checkmk/checkmk/tags | grep "name" | awk '{print substr($2, 3, length($2)-4) }' | head -n 1) root@test:~# echo "https://download.checkmk.com/checkmk/${RELEASE}/check-mk-raw-${RELEASE}_0.bookworm_amd64.deb" https://download.checkmk.com/checkmk/2.3.0/check-mk-raw-2.3.0_0.bookworm_amd64.deb ``` Also obverving these changed we see missing `head -n 1` postprocessing within the `ct/checkmk.sh`. Results of version fetching in `cf/checkmk-install.sh`: ``` root@test:~# RELEASE=$(curl -fsSL https://api.github.com/repos/checkmk/checkmk/tags | grep "name" | awk '{print substr($2, 3, length($2)-4) }') root@test:~# echo "https://download.checkmk.com/checkmk/${RELEASE}/check-mk-raw-${RELEASE}_0.bookworm_amd64.deb" https://download.checkmk.com/checkmk/2.3.0 2.3.0p26 2.3.0p26-rc1 2.3.0p25 2.3.0p25-rc1 2.3.0p24 2.3.0p24-rc1 2.3.0p23 2.3.0p23-rc1 2.3.0p22 2.3.0p22-rc1 2.3.0p21 2.3.0p21-rc2 2.3.0p21-rc1 2.3.0p20 2.3.0p20-rc2 2.3.0p20-rc1 2.3.0p19 2.3.0p19-rc2 2.3.0p19-rc1 2.3.0p18 2.3.0p18-rc3 2.3.0p18-rc2 2.3.0p18-rc1 2.3.0p17 2.3.0p17-rc3 2.3.0p17-rc2 2.3.0p17-rc1 2.3.0p16 2.3.0p16-rc1/check-mk-raw-2.3.0 2.3.0p26 2.3.0p26-rc1 2.3.0p25 2.3.0p25-rc1 2.3.0p24 2.3.0p24-rc1 2.3.0p23 2.3.0p23-rc1 2.3.0p22 2.3.0p22-rc1 2.3.0p21 2.3.0p21-rc2 2.3.0p21-rc1 2.3.0p20 2.3.0p20-rc2 2.3.0p20-rc1 2.3.0p19 2.3.0p19-rc2 2.3.0p19-rc1 2.3.0p18 2.3.0p18-rc3 2.3.0p18-rc2 2.3.0p18-rc1 2.3.0p17 2.3.0p17-rc3 2.3.0p17-rc2 2.3.0p17-rc1 2.3.0p16 2.3.0p16-rc1_0.bookworm_amd64.deb ``` This is probably also currently disabling the correct upgrade-precondition: `"${RELEASE}" != "$(cat /opt/${APP}_version.txt)"` ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? _No response_ ### 🔄 Steps to reproduce the issue. bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/checkmk.sh)" Observe: `$ cat /opt/checkmk_version.txt`: `2.3.0` However expected is: `2.3.0p26` ### ❌ Paste the full error output (if available). . ### 🖼️ Additional context (optional). _No response_
saavagebueno added the investigation label 2025-11-20 04:49:19 -05:00
saavagebueno commented 2025-11-20 04:49:20 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Feb 10, 2025):

Its pinned to minor and major released, non p or rc versions as i had troubles with them during the update process.
Mybee i have a look again when i have time.

@michelroegl-brunner commented on GitHub (Feb 10, 2025): Its pinned to minor and major released, non p or rc versions as i had troubles with them during the update process. Mybee i have a look again when i have time.
saavagebueno commented 2025-11-20 04:49:20 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Feb 11, 2025):

Merged.

@michelroegl-brunner commented on GitHub (Feb 11, 2025): Merged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label investigation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?