SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #4603] [MERGED] Website: harmonize all Logos | use jsDelivr CDN links for icons from selfhst/icons repo #5101

New Issue
Closed
opened 2025-11-20 07:04:18 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:04:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4603
Author: @MickLesk
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @tremor021

Base: main ← Head: jsons

📝 Commits (10+)

📊 Changes

329 files changed (+3962 additions, -4095 deletions)

View changed files

📝 frontend/public/json/2fauth.json (+41 -41)
📝 frontend/public/json/actualbudget.json (+1 -1)
📝 frontend/public/json/add-lxc-iptag.json (+4 -3)
📝 frontend/public/json/add-netbird-lxc.json (+1 -1)
📝 frontend/public/json/add-tailscale-lxc.json (+1 -1)
📝 frontend/public/json/adguard.json (+1 -2)
📝 frontend/public/json/adventurelog.json (+1 -1)
📝 frontend/public/json/agentdvr.json (+1 -1)
📝 frontend/public/json/all-templates.json (+4 -3)
📝 frontend/public/json/alpine-it-tools.json (+1 -1)
📝 frontend/public/json/alpine-tinyauth.json (+1 -1)
📝 frontend/public/json/alpine.json (+1 -12)
📝 frontend/public/json/apache-cassandra.json (+1 -1)
📝 frontend/public/json/apache-couchdb.json (+1 -1)
📝 frontend/public/json/apache-guacamole.json (+2 -3)
📝 frontend/public/json/apache-tika.json (+1 -1)
📝 frontend/public/json/apache-tomcat.json (+1 -2)
📝 frontend/public/json/apt-cacher-ng.json (+33 -33)
📝 frontend/public/json/archivebox.json (+1 -1)
📝 frontend/public/json/archlinux-vm.json (+1 -2)

...and 80 more files

📄 Description

✍️ Description

This PR updates the logo field in 335 JSON files under frontend/public/json/, replacing various GitHub or local icon URLs with CDN-hosted .webp assets from the selfhst/icons repository via jsDelivr.

Thanks to @shollyethan | @selfhst for all new created icons.

Changes

  • Standardized all logo fields to: 
    "logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/<name>.webp"
  • Old URLs (e.g., raw.githubusercontent.com, githubusercontent.com) removed or replaced.

Notes

  • All icons are now fetched via jsDelivr from the selfhst/icons repo.
  • Missing icons can be requested directly in the selfhst/icons GitHub repository.
  • No other fields in the JSON files were changed.

🔗 Related PR / Issue

Link: #4543
External: https://github.com/selfhst/icons/discussions/388

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4603 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `jsons` --- ### 📝 Commits (10+) - [`052786a`](https://github.com/community-scripts/ProxmoxVE/commit/052786ad273d3aa8c0fb88bf1ec58f4851a844d5) Update jsons - [`a4ccfde`](https://github.com/community-scripts/ProxmoxVE/commit/a4ccfdeaffec6593d17414e48621c9e89859366b) push - [`21016a9`](https://github.com/community-scripts/ProxmoxVE/commit/21016a97754022677de26ae0f50d6ae48c79b1b2) more - [`1531f95`](https://github.com/community-scripts/ProxmoxVE/commit/1531f95dafadd7ad3ba5b8b6dfeebc0122be4b1f) Switch to CDN - [`b06d505`](https://github.com/community-scripts/ProxmoxVE/commit/b06d505e5a3ee8fab90fe9b6918f3cd5d6844ba9) push new Icons into Branch - [`b6915fe`](https://github.com/community-scripts/ProxmoxVE/commit/b6915fe1f65f6b1d15683c16c2f2610c619eabd3) Update dotnetaspwebapi.json - [`2e19212`](https://github.com/community-scripts/ProxmoxVE/commit/2e1921280be92283275381f849731a2454f3212e) add proxmox logo - [`fb07451`](https://github.com/community-scripts/ProxmoxVE/commit/fb0745173112af2c7b9f286ee2653ee8b240b62a) Update wger.json - [`98cb3dc`](https://github.com/community-scripts/ProxmoxVE/commit/98cb3dc050e82bf16522ca1126a0c03ea2d8f347) switch to webp - [`31c4a9b`](https://github.com/community-scripts/ProxmoxVE/commit/31c4a9b171352ddba7ad573eb061e33cdeb07acf) Update apt-cacher-ng.json ### 📊 Changes **329 files changed** (+3962 additions, -4095 deletions) <details> <summary>View changed files</summary> 📝 `frontend/public/json/2fauth.json` (+41 -41) 📝 `frontend/public/json/actualbudget.json` (+1 -1) 📝 `frontend/public/json/add-lxc-iptag.json` (+4 -3) 📝 `frontend/public/json/add-netbird-lxc.json` (+1 -1) 📝 `frontend/public/json/add-tailscale-lxc.json` (+1 -1) 📝 `frontend/public/json/adguard.json` (+1 -2) 📝 `frontend/public/json/adventurelog.json` (+1 -1) 📝 `frontend/public/json/agentdvr.json` (+1 -1) 📝 `frontend/public/json/all-templates.json` (+4 -3) 📝 `frontend/public/json/alpine-it-tools.json` (+1 -1) 📝 `frontend/public/json/alpine-tinyauth.json` (+1 -1) 📝 `frontend/public/json/alpine.json` (+1 -12) 📝 `frontend/public/json/apache-cassandra.json` (+1 -1) 📝 `frontend/public/json/apache-couchdb.json` (+1 -1) 📝 `frontend/public/json/apache-guacamole.json` (+2 -3) 📝 `frontend/public/json/apache-tika.json` (+1 -1) 📝 `frontend/public/json/apache-tomcat.json` (+1 -2) 📝 `frontend/public/json/apt-cacher-ng.json` (+33 -33) 📝 `frontend/public/json/archivebox.json` (+1 -1) 📝 `frontend/public/json/archlinux-vm.json` (+1 -2) _...and 80 more files_ </details> ### 📄 Description ## ✍️ Description This PR updates the `logo` field in 335 JSON files under `frontend/public/json/`, replacing various GitHub or local icon URLs with CDN-hosted `.webp` assets from the [`selfhst/icons`](https://github.com/selfhst/icons) repository via [jsDelivr](https://cdn.jsdelivr.net/). Thanks to @shollyethan | @selfhst for all new created icons. ## Changes - Standardized all `logo` fields to: ``` "logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/<name>.webp" ``` - Old URLs (e.g., `raw.githubusercontent.com`, `githubusercontent.com`) removed or replaced. ## Notes - All icons are now fetched via jsDelivr from the `selfhst/icons` repo. - Missing icons can be requested directly in the `selfhst/icons` GitHub repository. - No other fields in the JSON files were changed. ## 🔗 Related PR / Issue Link: #4543 External: https://github.com/selfhst/icons/discussions/388 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:04:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?