SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 06:13:56 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #4827] fix: pulse script tar warnings and interactive prompts #5289

New Issue
Closed
opened 2025-11-20 07:05:14 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:05:14 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/4827

State: closed
Merged: No

Summary

Fixes issues with the Pulse installation script and corrects the installation workflow to follow proper community script conventions.

Changes Made

  • Suppress tar warnings: Added 2>/dev/null to tar extraction commands to suppress harmless extended header warnings on macOS
  • Remove interactive prompts: Eliminated credential prompts during LXC creation (incorrect workflow)
  • Use existing .env.example: Release tarball already includes detailed .env.example with comprehensive configuration options
  • Update systemd service: Use optional EnvironmentFile with - prefix so service can be enabled without .env file
  • Add post-install instructions: Clear guidance on how to configure Pulse after LXC creation

Issues Fixed

  1. Users seeing confusing tar warnings about LIBARCHIVE.xattr.com.apple.provenance
  2. Script incorrectly prompting for Proxmox credentials during LXC creation

Correct Workflow

The proper workflow is now:

  1. Community script creates LXC and installs Pulse (with detailed .env.example already included)
  2. User enters LXC and manually copies .env.example to .env
  3. User edits .env file with their Proxmox credentials using the detailed examples/comments
  4. User starts the pulse-monitor service when ready

Benefits

  • Users get the full detailed .env.example from the release with all configuration options and helpful comments
  • No interactive prompts during automated LXC creation
  • Follows standard community script patterns
  • Service is enabled but not started until user completes configuration

Test Plan

  • Verified tar extraction works without warnings
  • Confirmed LXC creation completes without prompts
  • Verified detailed .env.example is included from release tarball
  • Tested service can be enabled without .env file present

Files Changed

  • ct/pulse.sh - Added stderr redirection for tar command
  • install/pulse-install.sh - Removed interactive prompts, use existing .env.example, updated service config

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/4827 **State:** closed **Merged:** No --- ## Summary Fixes issues with the Pulse installation script and corrects the installation workflow to follow proper community script conventions. ## Changes Made - **Suppress tar warnings**: Added `2>/dev/null` to tar extraction commands to suppress harmless extended header warnings on macOS - **Remove interactive prompts**: Eliminated credential prompts during LXC creation (incorrect workflow) - **Use existing .env.example**: Release tarball already includes detailed .env.example with comprehensive configuration options - **Update systemd service**: Use optional EnvironmentFile with `-` prefix so service can be enabled without .env file - **Add post-install instructions**: Clear guidance on how to configure Pulse after LXC creation ## Issues Fixed 1. Users seeing confusing tar warnings about `LIBARCHIVE.xattr.com.apple.provenance` 2. Script incorrectly prompting for Proxmox credentials during LXC creation ## Correct Workflow The proper workflow is now: 1. Community script creates LXC and installs Pulse (with detailed .env.example already included) 2. User enters LXC and manually copies `.env.example` to `.env` 3. User edits `.env` file with their Proxmox credentials using the detailed examples/comments 4. User starts the pulse-monitor service when ready ## Benefits - Users get the full detailed `.env.example` from the release with all configuration options and helpful comments - No interactive prompts during automated LXC creation - Follows standard community script patterns - Service is enabled but not started until user completes configuration ## Test Plan - [x] Verified tar extraction works without warnings - [x] Confirmed LXC creation completes without prompts - [x] Verified detailed .env.example is included from release tarball - [x] Tested service can be enabled without .env file present ## Files Changed - `ct/pulse.sh` - Added stderr redirection for tar command - `install/pulse-install.sh` - Removed interactive prompts, use existing .env.example, updated service config 🤖 Generated with [Claude Code](https://claude.ai/code)
saavagebueno added the pull-request label 2025-11-20 07:05:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?