SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Error during MagicMirror LXC update #532

New Issue
Closed
opened 2025-11-20 04:49:43 -05:00 by saavagebueno · 17 comments
saavagebueno commented 2025-11-20 04:49:43 -05:00
Owner
Copy Link

Originally created by @briodan on GitHub (Feb 13, 2025).

Originally assigned to: @tremor021 on GitHub.

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

MagicMirror Server LXC

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/magicmirror.sh)"

📝 Provide a clear and concise description of the issue.

running the update command in the LXC console results in the following error:

Image

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

open LXC console in proxmox web interface

run upgrade command - bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/magicmirror.sh)"

select yet to update magicmirror

get error

❌ Paste the full error output (if available).

⠇ Updating MagicMirror LXC
[ERROR] in line 41: exit code 0: while executing command npm install --only=prod --omit=dev &> /dev/null

🖼️ Additional context (optional).

No response

Originally created by @briodan on GitHub (Feb 13, 2025). Originally assigned to: @tremor021 on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? MagicMirror Server LXC ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/magicmirror.sh)" ### 📝 Provide a clear and concise description of the issue. running the update command in the LXC console results in the following error: ![Image](https://github.com/user-attachments/assets/2fc2c946-825a-432a-afbc-32b4bcea805f) ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. open LXC console in proxmox web interface run upgrade command - bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/magicmirror.sh)" select yet to update magicmirror get error ### ❌ Paste the full error output (if available). ⠇ Updating MagicMirror LXC [ERROR] in line 41: exit code 0: while executing command npm install --only=prod --omit=dev &> /dev/null ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 04:49:43 -05:00
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 13, 2025):

can you please do npm --version and paste output here?

@tremor021 commented on GitHub (Feb 13, 2025): can you please do `npm --version` and paste output here?
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 13, 2025):

version 10.2.3

@briodan commented on GitHub (Feb 13, 2025): version 10.2.3
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 13, 2025):

how old is your lxc lol

@MickLesk commented on GitHub (Feb 13, 2025): how old is your lxc lol
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 13, 2025):

at least a year old if not older lol, the update command ran fine last i did it in November.

@briodan commented on GitHub (Feb 13, 2025): at least a year old if not older lol, the update command ran fine last i did it in November.
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 13, 2025):

Actually decided to go as no-fix... the app changed the way its installed and updated.
Will probably need to update the script to reflect those changes

@tremor021 commented on GitHub (Feb 13, 2025): Actually decided to go as no-fix... the app changed the way its installed and updated. Will probably need to update the script to reflect those changes
saavagebueno commented 2025-11-20 04:49:44 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 17, 2025):

Actually decided to go as no-fix... the app changed the way its installed and updated. Will probably need to update the script to reflect those changes

is the updated script backwards compatible with older installs for an upgrade or does it need a new install?

@briodan commented on GitHub (Feb 17, 2025): > Actually decided to go as no-fix... the app changed the way its installed and updated. Will probably need to update the script to reflect those changes is the updated script backwards compatible with older installs for an upgrade or does it need a new install?
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 17, 2025):

The merge that i See, both

@MickLesk commented on GitHub (Feb 17, 2025): The merge that i See, both
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 17, 2025):

does not work to upgrade for me, new error below

Image

@briodan commented on GitHub (Feb 17, 2025): does not work to upgrade for me, new error below ![Image](https://github.com/user-attachments/assets/b90f6367-7a8c-452e-afe6-acecc265f81f)
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 17, 2025):

Image
I can't reproduce the issue. The script basicaly just backs up the config file and custom css (if exists), then downloads the latest release and builds it.
you don't get to keep any of the old release files in the /opt/magicmirror so it can build clean

what version you updating from?

@tremor021 commented on GitHub (Feb 17, 2025): ![Image](https://github.com/user-attachments/assets/483f9fb4-a689-4d4a-98c1-0e0f4350fa70) I can't reproduce the issue. The script basicaly just backs up the config file and custom css (if exists), then downloads the latest release and builds it. you don't get to keep any of the old release files in the /opt/magicmirror so it can build clean what version you updating from?
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 17, 2025):

upgrading from 2.29.0.

@briodan commented on GitHub (Feb 17, 2025): upgrading from 2.29.0.
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 17, 2025):

can you do node -v for me please

@tremor021 commented on GitHub (Feb 17, 2025): can you do `node -v` for me please
saavagebueno commented 2025-11-20 04:49:45 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 17, 2025):

Image

@briodan commented on GitHub (Feb 17, 2025): ![Image](https://github.com/user-attachments/assets/93755ce3-df19-4aec-b2a2-a4aecf787568)
saavagebueno commented 2025-11-20 04:49:46 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 17, 2025):

it could be a Node issue as minimum is v20.18.1, i will add a check for node version in the update script and update it if needed.
for the time beign, install FileBrowser, download the config from /opt/magicmirror/config
install a fresh MagicMirror LXC and restore the config.

@tremor021 commented on GitHub (Feb 17, 2025): it could be a Node issue as minimum is v20.18.1, i will add a check for node version in the update script and update it if needed. for the time beign, install FileBrowser, download the config from /opt/magicmirror/config install a fresh MagicMirror LXC and restore the config.
saavagebueno commented 2025-11-20 04:49:46 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 17, 2025):

@briodan btw, can you do apt update && apt upgrade -y then do node -v again to check? it should bump the version to 20.18.3

If it does, can you try doing update again?

@tremor021 commented on GitHub (Feb 17, 2025): @briodan btw, can you do `apt update && apt upgrade -y` then do `node -v` again to check? it should bump the version to 20.18.3 If it does, can you try doing `update` again?
saavagebueno commented 2025-11-20 04:49:46 -05:00
Author
Owner
Copy Link

@briodan commented on GitHub (Feb 17, 2025):

its now at v20.18.3 and the update complete.

however i will note a couple of things, the initial script failure resulted in a couple of issues that prohibited future runs of the upgrade script:

  1. magicmirror-backup folder was left behind which prevents the script from running again
  2. looks like the backup function moved/deleted my config.js file from magicmirror/config folder as part of the process which also prevented the script from running as its could not fine the file on a subsequent run.

maybe a few extra checks/rollback could be added to the script to help in case of errors.

@briodan commented on GitHub (Feb 17, 2025): its now at v20.18.3 and the update complete. however i will note a couple of things, the initial script failure resulted in a couple of issues that prohibited future runs of the upgrade script: 1. magicmirror-backup folder was left behind which prevents the script from running again 2. looks like the backup function moved/deleted my config.js file from magicmirror/config folder as part of the process which also prevented the script from running as its could not fine the file on a subsequent run. maybe a few extra checks/rollback could be added to the script to help in case of errors.
saavagebueno commented 2025-11-20 04:49:46 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 17, 2025):

it copies config.js to backup folder and it should stay there in case update fails. for future updates, you're right. i will add a check for that case

@tremor021 commented on GitHub (Feb 17, 2025): it copies config.js to backup folder and it should stay there in case update fails. for future updates, you're right. i will add a check for that case
saavagebueno commented 2025-11-20 04:49:46 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Feb 18, 2025):

Will be fixed after #2468 merges

@tremor021 commented on GitHub (Feb 18, 2025): Will be fixed after #2468 merges
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?