SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #4950] [CLOSED] fix: improve Pulse installation with access URL output #5385

New Issue
Open
opened 2025-11-20 07:05:43 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:05:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4950
Author: @rcourtman
Created: 6/3/2025
Status: ❌ Closed

Base: main ← Head: fix/pulse-non-interactive-setup

📝 Commits (5)

  • f8f7466 fix: streamline Pulse installation for web-based configuration
  • 1dce264 Update pulse.sh to align with non-interactive installation
  • 0c632df little fixes
  • 9a835e3 Update pulse.sh
  • 2486738 fix: add final access URL output to Pulse installation

📊 Changes

3 files changed (+36 additions, -45 deletions)

View changed files

📝 ct/pulse.sh (+15 -18)
📝 frontend/public/json/pulse.json (+5 -1)
📝 install/pulse-install.sh (+16 -26)

📄 Description

Summary

  • Add missing final access URL output to Pulse installation script
  • Display IP and port (http://IP:7655) after successful setup completion
  • Align Pulse script with community script standards

Changes Made

  • Added msg_info "Installation Complete" message
  • Extract and display host IP address using hostname -I | awk '{print $1}'
  • Show clickable access URL with emoji: 🌐 Access Pulse: http://${IP}:7655
  • Added msg_ok "Pulse is ready" completion message

Motivation

The original Pulse installation script was missing the standard final output that shows users how to access their newly installed service. Most community scripts include this helpful information at the end of installation, and this brings Pulse in line with that standard.

Test plan

  • Verify script syntax is correct
  • Confirm output format matches community standards
  • Ensure IP detection works properly
  • Verified port 7655 is correct per pulse.json metadata

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4950 **Author:** [@rcourtman](https://github.com/rcourtman) **Created:** 6/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pulse-non-interactive-setup` --- ### 📝 Commits (5) - [`f8f7466`](https://github.com/community-scripts/ProxmoxVE/commit/f8f74662f41fbf137ebd6a4ebb37c0eaf827d599) fix: streamline Pulse installation for web-based configuration - [`1dce264`](https://github.com/community-scripts/ProxmoxVE/commit/1dce264b5cb82ee7e0b5bcd086fda2ee38955ea1) Update pulse.sh to align with non-interactive installation - [`0c632df`](https://github.com/community-scripts/ProxmoxVE/commit/0c632df3a570f60fb7a67e4f78ff3a30046ebefc) little fixes - [`9a835e3`](https://github.com/community-scripts/ProxmoxVE/commit/9a835e3303cf31d8068113d48fc6a9eca9718611) Update pulse.sh - [`2486738`](https://github.com/community-scripts/ProxmoxVE/commit/24867389357e67ee86798ff3f494d30036e2d729) fix: add final access URL output to Pulse installation ### 📊 Changes **3 files changed** (+36 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `ct/pulse.sh` (+15 -18) 📝 `frontend/public/json/pulse.json` (+5 -1) 📝 `install/pulse-install.sh` (+16 -26) </details> ### 📄 Description ## Summary - Add missing final access URL output to Pulse installation script - Display IP and port (http://IP:7655) after successful setup completion - Align Pulse script with community script standards ## Changes Made - Added `msg_info "Installation Complete"` message - Extract and display host IP address using `hostname -I | awk '{print $1}'` - Show clickable access URL with emoji: `🌐 Access Pulse: http://${IP}:7655` - Added `msg_ok "Pulse is ready"` completion message ## Motivation The original Pulse installation script was missing the standard final output that shows users how to access their newly installed service. Most community scripts include this helpful information at the end of installation, and this brings Pulse in line with that standard. ## Test plan - [x] Verify script syntax is correct - [x] Confirm output format matches community standards - [x] Ensure IP detection works properly - [x] Verified port 7655 is correct per pulse.json metadata 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:05:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?