SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-22 13:53:40 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #5072] tools.func: remove output suppression for messages #5497

New Issue
Open
opened 2025-11-20 07:06:14 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:06:14 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/5072

State: closed
Merged: No

✍️ Description

Several msg_info and msg_ok messages were suppressed by $STD in this function. I noticed it when I was using it to install Ruby. I don't know if this was simply missed or if there is a reason for it, so please let me know if it was intentional.

  • In the Ruby install function the make command would produce output so I added $STD there.

In Prerequisites below, tested thoroughly is unchecked because I have only tested the Ruby install to ensure it still works. Although I don't forsee an issue, I'm thinking that for such a change, you may want me to verify by doing a test run for each function. That's why it's a draft.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/5072 **State:** closed **Merged:** No --- ## ✍️ Description Several `msg_info` and `msg_ok` messages were suppressed by `$STD` in this function. I noticed it when I was using it to install Ruby. I don't know if this was simply missed or if there is a reason for it, so please let me know if it was intentional. - In the Ruby install function the `make` command would produce output so I added `$STD` there. In Prerequisites below, **tested thoroughly** is unchecked because I have only tested the Ruby install to ensure it still works. Although I don't forsee an issue, I'm thinking that for such a change, you may want me to verify by doing a test run for each function. That's why it's a draft. ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.
saavagebueno added the pull-request label 2025-11-20 07:06:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?