SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Pihole fails with #561

New Issue
Closed
opened 2025-11-20 04:50:13 -05:00 by saavagebueno · 20 comments
saavagebueno commented 2025-11-20 04:50:13 -05:00
Owner
Copy Link

Originally created by @nicedevil007 on GitHub (Feb 19, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Pihole

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pihole.sh)"

📝 Provide a clear and concise description of the issue.

Pihole isn't installable.

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

  1. Run the script
  2. see the error

❌ Paste the full error output (if available).

____  _ __          __

/ __ () / ____ / /__
/ // / / __ / __ / / _
/ / / / / / // / / __/
// /// //_//_/

🧩 Using Advanced Settings on node node01
🖥️ Operating System: debian
🌟 Version: 12
📦 Container Type: Unprivileged
🔐 Root Password: ********
🆔 Container ID: 12001
🏠 Hostname: pihole
💾 Disk Size: 2 GB
🧠 CPU Cores: 1
🛠️ RAM Size: 512 MiB
🌉 Bridge: vmbr0
📡 IP Address: dhcp
🌐 Gateway IP Address: Default
📡 APT-Cacher IP Address: Default
🚫 Disable IPv6: no
⚙️ Interface MTU Size: Default
🔍 DNS Search Domain: Host
📡 DNS Server IP Address: Host
🏷️ Vlan: 12
📡 Tags: ;
🔑 Root SSH Access: yes
Warning: No SSH key provided.
🔍 Verbose Mode: no
🚀 Creating a Pihole LXC using the above advanced settings
✔️ Using local for Template Storage.
✔️ Using storage for Container Storage.
✔️ Updated LXC Template List
✔️ LXC Container 42001 was successfully created.
✔️ Started LXC Container
✔️ Set up Container OS
✔️ Network Connected: 10.0.12.19
✔️ IPv4 Internet Connected
✖️ IPv6 Internet Not Connected
✔️ DNS Resolved github.com to 140.82.121.3
✔️ Updated Container OS
✔️ Installed Dependencies
✔️ Installed Pi-hole
Would you like to add Unbound? <y/N> y
Unbound is configured as a recursive DNS server by default, would you like it to be configured as a forwarding DNS server (using DNS-over-TLS (DoT)) instead? <y/N>
⠦sed: can't read /etc/pihole/setupVars.conf: No such file or directory
⠧
[ERROR] in line 123: exit code 0: while executing command sed -i -e 's/PIHOLE_DNS_1=8.8.8.8/PIHOLE_DNS_1=127.0.0.1#5335/' -e '/PIHOLE_DNS_2=8.8.4.4/d' /etc/pihole/setupVars.conf

🖼️ Additional context (optional).

No response

Originally created by @nicedevil007 on GitHub (Feb 19, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Pihole ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pihole.sh)" ### 📝 Provide a clear and concise description of the issue. Pihole isn't installable. ### ⚙️ What settings are you using? - [ ] Default Settings - [x] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. 1. Run the script 2. see the error ### ❌ Paste the full error output (if available). ____ _ __ __ / __ \(_) /_ ____ / /__ / /_/ / / __ \/ __ \/ / _ \ / ____/ / / / / /_/ / / __/ /_/ /_/_/ /_/\____/_/\___/ 🧩 Using Advanced Settings on node node01 🖥️ Operating System: debian 🌟 Version: 12 📦 Container Type: Unprivileged 🔐 Root Password: ******** 🆔 Container ID: 12001 🏠 Hostname: pihole 💾 Disk Size: 2 GB 🧠 CPU Cores: 1 🛠️ RAM Size: 512 MiB 🌉 Bridge: vmbr0 📡 IP Address: dhcp 🌐 Gateway IP Address: Default 📡 APT-Cacher IP Address: Default 🚫 Disable IPv6: no ⚙️ Interface MTU Size: Default 🔍 DNS Search Domain: Host 📡 DNS Server IP Address: Host 🏷️ Vlan: 12 📡 Tags: ; 🔑 Root SSH Access: yes Warning: No SSH key provided. 🔍 Verbose Mode: no 🚀 Creating a Pihole LXC using the above advanced settings ✔️ Using local for Template Storage. ✔️ Using storage for Container Storage. ✔️ Updated LXC Template List ✔️ LXC Container 42001 was successfully created. ✔️ Started LXC Container ✔️ Set up Container OS ✔️ Network Connected: 10.0.12.19 ✔️ IPv4 Internet Connected ✖️ IPv6 Internet Not Connected ✔️ DNS Resolved github.com to 140.82.121.3 ✔️ Updated Container OS ✔️ Installed Dependencies ✔️ Installed Pi-hole Would you like to add Unbound? <y/N> y Unbound is configured as a recursive DNS server by default, would you like it to be configured as a forwarding DNS server (using DNS-over-TLS (DoT)) instead? <y/N> ⠦sed: can't read /etc/pihole/setupVars.conf: No such file or directory ⠧ [ERROR] in line 123: exit code 0: while executing command sed -i -e 's/PIHOLE_DNS_1=8.8.8.8/PIHOLE_DNS_1=127.0.0.1#5335/' -e '/PIHOLE_DNS_2=8.8.4.4/d' /etc/pihole/setupVars.conf ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 04:50:13 -05:00
saavagebueno commented 2025-11-20 04:50:14 -05:00
Author
Owner
Copy Link

@tommetje commented on GitHub (Feb 19, 2025):

Yesterday pi-hole v6.0 was released, many changes and additions.

Updating the LXC with the update or pihole -up seems to break things. Updating using the first method at least makes the dashboard inaccessible, the latter throws an error in proxmox and the LXC is not bootable anymore.

@tommetje commented on GitHub (Feb 19, 2025): Yesterday pi-hole v6.0 was released, many changes and additions. Updating the LXC with the `update` or `pihole -up` seems to break things. Updating using the first method at least makes the dashboard inaccessible, the latter throws an error in proxmox and the LXC is not bootable anymore.
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

Image

whats your change? IPV6?

@MickLesk commented on GitHub (Feb 19, 2025): <img width="546" alt="Image" src="https://github.com/user-attachments/assets/ca67526d-8dc2-41d0-8f32-68d143c7f61f" /> whats your change? IPV6?
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@pictosun commented on GitHub (Feb 19, 2025):

I think it needs to be a rewrite of the script for Pi Hole overall. So many things changed.

@pictosun commented on GitHub (Feb 19, 2025): I think it needs to be a rewrite of the script for Pi Hole overall. So many things changed.
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

I think it needs to be a rewrite of the script for Pi Hole overall. So many things changed.

i think not. Because the script do nothing 😄 the script simply execute the function of pihole himself.

Same function call like the official docu.

@MickLesk commented on GitHub (Feb 19, 2025): > I think it needs to be a rewrite of the script for Pi Hole overall. So many things changed. i think not. Because the script do nothing :smile: the script simply execute the function of pihole himself. Same function call like the official docu.
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@pictosun commented on GitHub (Feb 19, 2025):

@MickLesk As far as I understand the config files are now at /etc/pihole/pihole.toml - That's new - and the cript does write into conf files. So maybe this is a point?

@pictosun commented on GitHub (Feb 19, 2025): @MickLesk As far as I understand the config files are now at /etc/pihole/pihole.toml - That's new - and the cript does write into conf files. So maybe this is a point?
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@gael1980 commented on GitHub (Feb 19, 2025):

You also need to disable ntp in pihole config. This doesn't work with proxmox :

https://discourse.pi-hole.net/t/failed-to-adjust-time-during-ntp-sync-insufficient-permissions/70966

@gael1980 commented on GitHub (Feb 19, 2025): You also need to disable ntp in pihole config. This doesn't work with proxmox : https://discourse.pi-hole.net/t/failed-to-adjust-time-during-ntp-sync-insufficient-permissions/70966
saavagebueno commented 2025-11-20 04:50:15 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

You also need to disable ntp in pihole config. This doesn't work with proxmox :

https://discourse.pi-hole.net/t/failed-to-adjust-time-during-ntp-sync-insufficient-permissions/70966

i know, i have this already so in my dev. im at testing...

@MickLesk commented on GitHub (Feb 19, 2025): > You also need to disable ntp in pihole config. This doesn't work with proxmox : > > https://discourse.pi-hole.net/t/failed-to-adjust-time-during-ntp-sync-insufficient-permissions/70966 i know, i have this already so in my dev. im at testing...
saavagebueno commented 2025-11-20 04:50:16 -05:00
Author
Owner
Copy Link

@nicedevil007 commented on GitHub (Feb 19, 2025):

Image

whats your change? IPV6?
I used a VLAN.
I thought my changes are visible from the log output.

Try it with adding unbound.

@nicedevil007 commented on GitHub (Feb 19, 2025): > <img width="546" alt="Image" src="https://github.com/user-attachments/assets/ca67526d-8dc2-41d0-8f32-68d143c7f61f" /> > > whats your change? IPV6? I used a VLAN. I thought my changes are visible from the log output. Try it with adding unbound.
saavagebueno commented 2025-11-20 04:50:16 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

Image

whats your change? IPV6?
I used a VLAN.
I thought my changes are visible from the log output.

Try it with adding unbound.

Okay fixed in my Dev Branch. I Test it and give an bash curl later, because i cannot Test completly without Change my infrastructure ^^

@MickLesk commented on GitHub (Feb 19, 2025): > > <img width="546" alt="Image" src="https://github.com/user-attachments/assets/ca67526d-8dc2-41d0-8f32-68d143c7f61f" /> > > > > whats your change? IPV6? > I used a VLAN. > I thought my changes are visible from the log output. > > Try it with adding unbound. Okay fixed in my Dev Branch. I Test it and give an bash curl later, because i cannot Test completly without Change my infrastructure ^^
saavagebueno commented 2025-11-20 04:50:16 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

so, i have an tested script.. can anyone confirm? Especially with unbound?

bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)"

Now I just have to think about how I can migrate an existing installation. Apparently the biggest part (migration from .conf to .toml) is already done by PiHole itself.

@MickLesk commented on GitHub (Feb 19, 2025): so, i have an tested script.. can anyone confirm? Especially with unbound? ```bash bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)" ``` Now I just have to think about how I can migrate an existing installation. Apparently the biggest part (migration from .conf to .toml) is already done by PiHole itself.
saavagebueno commented 2025-11-20 04:50:16 -05:00
Author
Owner
Copy Link

@kilnake commented on GitHub (Feb 19, 2025):

@MickLesk : i tried your script, seems like it is almost working. but it is not seeing the unbound and still using googles dns.

DNSMASQ_WARN	Warning in dnsmasq core:

no upstream servers configured
@kilnake commented on GitHub (Feb 19, 2025): @MickLesk : i tried your script, seems like it is almost working. but it is not seeing the unbound and still using googles dns. ``` DNSMASQ_WARN Warning in dnsmasq core: no upstream servers configured ```
saavagebueno commented 2025-11-20 04:50:16 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

Can you Test again? Pushed an commit 5min ago

@MickLesk commented on GitHub (Feb 19, 2025): Can you Test again? Pushed an commit 5min ago
saavagebueno commented 2025-11-20 04:50:17 -05:00
Author
Owner
Copy Link

@kilnake commented on GitHub (Feb 19, 2025):

EDIT: I ran two scenarios, one with unbound and other without unbound. Both had same error listed below.

Same error : "no upstream servers configured"

&& was it meant to be changed "install unbound" default to no?

@kilnake commented on GitHub (Feb 19, 2025): EDIT: I ran two scenarios, one with unbound and other without unbound. Both had same error listed below. Same error : "no upstream servers configured" && was it meant to be changed "install unbound" default to no?
saavagebueno commented 2025-11-20 04:50:17 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

now you can test

@MickLesk commented on GitHub (Feb 19, 2025): now you can test
saavagebueno commented 2025-11-20 04:50:17 -05:00
Author
Owner
Copy Link

@SiriusLightning21 commented on GitHub (Feb 19, 2025):

My pihole v6.0 with unbound also crashed. So I can test it with unbound if needed😉

@SiriusLightning21 commented on GitHub (Feb 19, 2025): My pihole v6.0 with unbound also crashed. So I can test it with unbound if needed😉
saavagebueno commented 2025-11-20 04:50:17 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

yeah, you can test it here:

bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)"

They changed so much... annoying

@MickLesk commented on GitHub (Feb 19, 2025): yeah, you can test it here: ```bash bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)" ``` They changed so much... annoying
saavagebueno commented 2025-11-20 04:50:17 -05:00
Author
Owner
Copy Link

@SiriusLightning21 commented on GitHub (Feb 19, 2025):

yeah, you can test it here:

bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)"

They changed so much... annoying

For now its working. DNS Leaktest will show my Unbound and piholes webpage is available with https.

@SiriusLightning21 commented on GitHub (Feb 19, 2025): > yeah, you can test it here: > > ```bash > bash -c "$(wget -qLO - https://github.com/MickLesk/Proxmox_DEV/raw/main/ct/pihole.sh)" > ``` > > They changed so much... annoying For now its working. DNS Leaktest will show my Unbound and piholes webpage is available with https.
saavagebueno commented 2025-11-20 04:50:18 -05:00
Author
Owner
Copy Link

@Wendigogo commented on GitHub (Feb 19, 2025):

Wow, great!
I guess I'll remove my LXC Pi-hole and add a new one from this script. I updated from pihole -up and got NTP issue described earlier. It's solved but it may be cleaner to restart it from scratch using Teleporter to restore my configuration.

Do you plan to switch new install to Alpine Linux as Pihole is?

Thanks

@Wendigogo commented on GitHub (Feb 19, 2025): Wow, great! I guess I'll remove my LXC Pi-hole and add a new one from this script. I updated from `pihole -up` and got NTP issue described earlier. It's solved but it may be cleaner to restart it from scratch using _Teleporter_ to restore my configuration. Do you plan to switch new install to Alpine Linux as Pihole is? Thanks
saavagebueno commented 2025-11-20 04:50:18 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 19, 2025):

maybe. i create tomorrow an short migration guide and create an pr about this

@MickLesk commented on GitHub (Feb 19, 2025): maybe. i create tomorrow an short migration guide and create an pr about this
saavagebueno commented 2025-11-20 04:50:18 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Feb 20, 2025):

merged fix + read breaking change discussion

@michelroegl-brunner commented on GitHub (Feb 20, 2025): merged fix + read breaking change discussion
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?