SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #5319] [CLOSED] Refactor: migrate Jupyter Notebook to uv-based installation with update support #5708

New Issue
Closed
opened 2025-11-20 07:07:15 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:07:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5319
Author: @MickLesk
Created: 6/20/2025
Status: ❌ Closed

Base: main ← Head: uv_jupyter

📝 Commits (2)

  • 2c68e35 Refactor: migrate AdventureLog update to uv and GitHub release logic
  • 2f1ded3 Refactor: migrate Jupyter Notebook to uv-based installation with update support

📊 Changes

4 files changed (+104 additions, -56 deletions)

View changed files

📝 ct/adventurelog.sh (+25 -17)
📝 ct/jupyternotebook.sh (+50 -11)
📝 install/adventurelog-install.sh (+17 -19)
📝 install/jupyternotebook-install.sh (+12 -9)

📄 Description

✍️ Description

This PR refactors the installation and update logic for Jupyter Notebook to use the modern uv-based Python virtual environment under /opt/jupyter.
It ensures consistent, isolated package management and replaces legacy pip3 install jupyter usage.

Additionally, the update_script():

  • Migrates legacy containers using system-wide Python to uv venv
  • Updates existing .venv installations
  • Rewrites the systemd service if it still references the legacy jupyter binary

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5319 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 6/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `uv_jupyter` --- ### 📝 Commits (2) - [`2c68e35`](https://github.com/community-scripts/ProxmoxVE/commit/2c68e35d2b294b04a11de09d7df4df466b01825e) Refactor: migrate AdventureLog update to uv and GitHub release logic - [`2f1ded3`](https://github.com/community-scripts/ProxmoxVE/commit/2f1ded3204f25a7f76f0873d48921d00b3d4cb4d) Refactor: migrate Jupyter Notebook to uv-based installation with update support ### 📊 Changes **4 files changed** (+104 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `ct/adventurelog.sh` (+25 -17) 📝 `ct/jupyternotebook.sh` (+50 -11) 📝 `install/adventurelog-install.sh` (+17 -19) 📝 `install/jupyternotebook-install.sh` (+12 -9) </details> ### 📄 Description ## ✍️ Description This PR refactors the installation and update logic for **Jupyter Notebook** to use the modern `uv`-based Python virtual environment under `/opt/jupyter`. It ensures consistent, isolated package management and replaces legacy `pip3 install jupyter` usage. Additionally, the `update_script()`: - Migrates legacy containers using system-wide Python to `uv venv` - Updates existing `.venv` installations - Rewrites the systemd service if it still references the legacy `jupyter` binary ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:07:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5708
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?