SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #5422] [core]: Improve GitHub release fetch robustness with split timeouts and retry logic #5788

New Issue
Closed
opened 2025-11-20 07:07:36 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:07:36 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/5422

State: closed
Merged: Yes

✍️ Description

This PR improves the robustness of the fetch_and_deploy_gh_release function by:

  • Splitting curl timeout handling:
    • API fetch now uses --connect-timeout 5 --max-time 30
    • Asset downloads use --connect-timeout 15 --max-time 900
  • Adding retry logic for GitHub API metadata fetch (3 attempts with 2s delay)
  • Preventing unnecessary download aborts for large prebuilds (e.g. Immich tarballs >150MB)
  • No functional changes to the function signature or behavior

These improvements make the function more resilient in environments with slow or unstable networks.

🔗 Related PR / Issue

#5387

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix
  • ✨ New feature (non-breaking robustness enhancement)
  • 💥 Breaking change
  • 🆕 New script
  • 🌍 Website update
  • 🔧 Refactoring / Code Cleanup
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/5422 **State:** closed **Merged:** Yes --- ## ✍️ Description This PR improves the robustness of the `fetch_and_deploy_gh_release` function by: - Splitting `curl` timeout handling: - API fetch now uses `--connect-timeout 5 --max-time 30` - Asset downloads use `--connect-timeout 15 --max-time 900` - Adding retry logic for GitHub API metadata fetch (3 attempts with 2s delay) - Preventing unnecessary download aborts for large prebuilds (e.g. Immich tarballs >150MB) - No functional changes to the function signature or behavior These improvements make the function more resilient in environments with slow or unstable networks. ## 🔗 Related PR / Issue #5387 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** - [x] ✨ **New feature** (non-breaking robustness enhancement) - [ ] 💥 **Breaking change** - [ ] 🆕 **New script** - [ ] 🌍 **Website update** - [ ] 🔧 **Refactoring / Code Cleanup**
saavagebueno added the pull-request label 2025-11-20 07:07:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?