SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Pihole Update + Documentation - since 6.0 #581

New Issue
Closed
opened 2025-11-20 04:50:35 -05:00 by saavagebueno · 3 comments
saavagebueno commented 2025-11-20 04:50:35 -05:00
Owner
Copy Link

Originally created by @nicedevil007 on GitHub (Feb 22, 2025).

Originally assigned to: @michelroegl-brunner on GitHub.

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Pihole

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pihole.sh)"

📝 Provide a clear and concise description of the issue.

Pihole Update isn't working anymore because the pihole command isn't found after installation:

Image

I figured out that the pihole command is located here:

root@pihole:~# find / -name pihole
/usr/local/bin/pihole

Further debugging shows that this path isn't available in the $PATH variable:

root@pihole:~# echo $PATH
/sbin:/bin:/usr/sbin:/usr/bin

I added export PATH="/usr/local/bin:$PATH" to my .bashrc and it was fixed.

An other thing I figured out is that this is not working anymore:

Image

It should be this:

Image

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

Install pihole, wait until update is available and run the script inside the container.

❌ Paste the full error output (if available).

____  _ __          __

/ __ () / ____ / /__
/ // / / __ / __ / / _
/ / / / / / // / / __/
// /// //_//_/

⠋environment: line 32: pihole: command not found
⠙
[ERROR] in line 32: exit code 0: while executing command pihole -up

✔️ Updated Pihole

🖼️ Additional context (optional).

No response

Originally created by @nicedevil007 on GitHub (Feb 22, 2025). Originally assigned to: @michelroegl-brunner on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Pihole ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pihole.sh)" ### 📝 Provide a clear and concise description of the issue. Pihole Update isn't working anymore because the pihole command isn't found after installation: ![Image](https://github.com/user-attachments/assets/ec8251f3-5271-41ca-8576-bfcc95e79e49) I figured out that the pihole command is located here: ```bash root@pihole:~# find / -name pihole /usr/local/bin/pihole ``` Further debugging shows that this path isn't available in the $PATH variable: ```bash root@pihole:~# echo $PATH /sbin:/bin:/usr/sbin:/usr/bin ``` I added `export PATH="/usr/local/bin:$PATH"` to my `.bashrc` and it was fixed. An other thing I figured out is that this is not working anymore: ![Image](https://github.com/user-attachments/assets/3d70c231-bcab-46fa-9e38-a034ba83b1ed) It should be this: ![Image](https://github.com/user-attachments/assets/ef5a8b0d-ac7f-491c-8e58-eec35adb0c0b) ### ⚙️ What settings are you using? - [ ] Default Settings - [x] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. Install pihole, wait until update is available and run the script inside the container. ### ❌ Paste the full error output (if available). ____ _ __ __ / __ \(_) /_ ____ / /__ / /_/ / / __ \/ __ \/ / _ \ / ____/ / / / / /_/ / / __/ /_/ /_/_/ /_/\____/_/\___/ ⠋environment: line 32: pihole: command not found ⠙ [ERROR] in line 32: exit code 0: while executing command pihole -up ✔️ Updated Pihole ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 04:50:35 -05:00
saavagebueno commented 2025-11-20 04:50:36 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Feb 22, 2025):

You pct enter the LXC to update? Thats an Proxmox Bug. On LXC self it works

@MickLesk commented on GitHub (Feb 22, 2025): You pct enter the LXC to update? Thats an Proxmox Bug. On LXC self it works
saavagebueno commented 2025-11-20 04:50:36 -05:00
Author
Owner
Copy Link

@githubaff0 commented on GitHub (Feb 23, 2025):

pihole -a -p
pihole setpassword

I just created new pihole LXC via helper script. I can confirm the command shown on the webpage to set the pihole web password should be changed to pihole setpassword.

root@pihole:~# pihole -a -p
Usage: pihole [options]
Example: 'pihole allow -h'
Add '-h' after specific commands for more information on usage
...
Options:
  setpassword [pwd]   Set the password for the web interface
                        Without optional argument, password is read interactively.
                        When specifying a password directly, enclose it in single quotes.
...

root@pihole:~# pihole setpassword
Enter New Password (Blank for no password): 
Confirm Password: 
  [✓] New password set

Also, it may be good to change the URL shown at the end of the install to https instead of http. If you use the http URL, the pihole admin login page warns 'Insecure network connection' and suggests 'Consider upgrading to HTTPS) (end-to-end encryption)`.

@githubaff0 commented on GitHub (Feb 23, 2025): > pihole -a -p > pihole setpassword I just created new pihole LXC via helper script. I can confirm the command shown on the webpage to set the pihole web password should be changed to `pihole setpassword`. ``` root@pihole:~# pihole -a -p Usage: pihole [options] Example: 'pihole allow -h' Add '-h' after specific commands for more information on usage ... Options: setpassword [pwd] Set the password for the web interface Without optional argument, password is read interactively. When specifying a password directly, enclose it in single quotes. ... root@pihole:~# pihole setpassword Enter New Password (Blank for no password): Confirm Password: [✓] New password set ``` Also, it may be good to change the URL shown at the end of the install to `https` instead of `http`. If you use the `http` URL, the pihole admin login page warns 'Insecure network connection' and suggests 'Consider upgrading to HTTPS) (end-to-end encryption)`.
saavagebueno commented 2025-11-20 04:50:36 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Feb 24, 2025):

i can not reproduce your path issue, it works out of the box for me.

Image

The json will get changed to the new command,

@michelroegl-brunner commented on GitHub (Feb 24, 2025): i can not reproduce your path issue, it works out of the box for me. ![Image](https://github.com/user-attachments/assets/b78f237b-b1f5-4c7b-a167-424280167b53) The json will get changed to the new command,
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?