SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-23 06:13:56 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #5464] [MERGED] Enhance InstallCommand component to support Gitea as an alternative source for installation scripts. #5824

New Issue
Closed
opened 2025-11-20 07:07:46 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:07:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5464
Author: @BramSuurdje
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @tremor021

Base: main ← Head: add-gitea-option-to-install

📝 Commits (1)

  • d073a34 Enhance InstallCommand component to support Gitea as an alternative source for installation scripts. Added informational alert for Gitea usage and refactored command generation logic to accommodate the new option.

📊 Changes

1 file changed (+48 additions, -13 deletions)

View changed files

📝 frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx (+48 -13)

📄 Description

✍️ Description

This pull request enhances the InstallCommand component in InstallCommand.tsx to support installation scripts from a Gitea mirror as an alternative to GitHub. It also introduces a UI element to inform users about when to use Gitea. The most important changes include updates to the installation command logic, the addition of Gitea-specific tabs, and the inclusion of an informational alert.

Gitea Mirror Support:

  • Updated getInstallCommand function: Added support for generating installation commands using a Gitea mirror URL as an alternative to GitHub. This is controlled by the new useGitea parameter.

UI Enhancements:

  • Added informational alert: Introduced an Alert component to inform users about scenarios where using the Gitea mirror is preferable, such as API rate limits or lack of IPv6 support.
  • Added Gitea-specific tabs: Modified the InstallCommand component to include tabs for selecting between GitHub and Gitea sources, with dynamic rendering of installation commands based on the selected source.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5464 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `add-gitea-option-to-install` --- ### 📝 Commits (1) - [`d073a34`](https://github.com/community-scripts/ProxmoxVE/commit/d073a344ea63344e7212ee7e024f43861b4fc9f0) Enhance InstallCommand component to support Gitea as an alternative source for installation scripts. Added informational alert for Gitea usage and refactored command generation logic to accommodate the new option. ### 📊 Changes **1 file changed** (+48 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx` (+48 -13) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description This pull request enhances the `InstallCommand` component in `InstallCommand.tsx` to support installation scripts from a Gitea mirror as an alternative to GitHub. It also introduces a UI element to inform users about when to use Gitea. The most important changes include updates to the installation command logic, the addition of Gitea-specific tabs, and the inclusion of an informational alert. ### Gitea Mirror Support: * **Updated `getInstallCommand` function**: Added support for generating installation commands using a Gitea mirror URL as an alternative to GitHub. This is controlled by the new `useGitea` parameter. ### UI Enhancements: * **Added informational alert**: Introduced an `Alert` component to inform users about scenarios where using the Gitea mirror is preferable, such as API rate limits or lack of IPv6 support. * **Added Gitea-specific tabs**: Modified the `InstallCommand` component to include tabs for selecting between GitHub and Gitea sources, with dynamic rendering of installation commands based on the selected source. ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. ![image](https://github.com/user-attachments/assets/93bf06d7-8290-484b-b1b1-da7e294a14b5) ![image](https://github.com/user-attachments/assets/d9a13807-2729-4b0e-b830-b35d589a3553) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:07:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#5824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?