SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Automatically Assign tailscale Tag to LXC After Successful Script Execution #597

New Issue
Closed
opened 2025-11-20 04:50:48 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:50:48 -05:00
Owner
Copy Link

Originally created by @bannert1337 on GitHub (Feb 25, 2025).

Originally assigned to: @michelroegl-brunner on GitHub.

🌟 Briefly describe the feature

This feature enhances the Tailscale installation script by automatically assigning a tailscale tag to the LXC once the script successfully completes. The tag serves as a clear identifier, allowing users to easily distinguish LXCs configured with Tailscale for improved organization, management, and workflow integration.

📝 Detailed description

This feature enhances the Tailscale installation script by introducing functionality to automatically assign a tailscale tag to the LXC container after the script successfully completes its execution. The tag acts as a label to identify the container as configured for Tailscale, improving ease of management and organization for users running multiple LXCs within their Proxmox environment.

Key Behavior:

  • At the end of the Tailscale script, after installation and configuration steps are successfully completed, a tailscale tag should be added to the LXC container.
  • If the script fails at any point or does not complete, the tag should not be added, ensuring accuracy in tagging.
  • The feature can leverage Proxmox's built-in tagging mechanism (pct set <LXC-ID> -tags tailscale) to update the container's metadata.

Key Benefits:

  1. Ease of Identification: Users can instantly recognize which containers are configured to use Tailscale. This is particularly helpful in environments with numerous containers.
  2. Reduced User Intervention: Automating the tagging process removes the need for manual tagging, reducing user workload and the potential for oversight.
  3. Improved Workflow: Tags can be filtered, queried, or used in other scripts or systems managing Proxmox resources, simplifying complex workflows.
  4. Error Prevention: Tagging only upon successful script execution ensures accuracy, preventing containers without complete Tailscale setups from being mislabeled.

Implementation Considerations:

  • The script should verify if the Proxmox pct tool supports adding tags (available in modern versions of Proxmox VE).
  • Add error-handling to ensure that the tagging step does not interrupt or delay the overall script functionality. Logging should indicate whether the tag was successfully added.
  • Make sure the tagging step is only executed for valid LXC containers configured with Tailscale (e.g., skip tagging if the script is tested on unsupported distributions like Alpine).

This feature aims to enhance overall usability and organization, making the script more user-friendly for complex Proxmox deployments.

💡 Why is this useful?

Automatically assigning a tailscale tag to the LXC upon completion of the script can be useful for several reasons:

  1. Improved Organization:
    In setups with multiple containers, it can be difficult to track which ones have specific configurations or services applied. A tailscale tag acts as a quick identifier, saving time and reducing confusion when managing multiple LXCs.

  2. Simplified Management:
    Tags enable easier filtering or grouping of LXCs in tools or interfaces where that is supported. For example, if you're managing your containers via the Proxmox Web UI or API, it becomes much easier to search or sort for containers with specific roles.

  3. Reduced Human Error:
    Adding the tag manually requires users to remember to do so after running the script, which is prone to oversight. Automating this removes an extra step for the user and ensures consistency.

  4. Easier Debugging:
    If an issue arises later, identifying all Tailscale-configured containers quickly can narrow down the scope of troubleshooting. The tag provides a clear indication that the container is associated with Tailscale setup.

  5. Improved Workflow for Advanced Users:
    Users scripting or automating their Proxmox LXC workflows could integrate the tagging mechanism into additional scripts or processes—like backups or updates—without adding redundant steps to check Tailscale's setup manually.

Overall, adding the tag aligns with good systems management practices by promoting clarity, automation, and ease of use. It’s a small but meaningful quality-of-life improvement for administrators and users of the script.

Originally created by @bannert1337 on GitHub (Feb 25, 2025). Originally assigned to: @michelroegl-brunner on GitHub. ### 🌟 Briefly describe the feature This feature enhances the Tailscale installation script by automatically assigning a tailscale tag to the LXC once the script successfully completes. The tag serves as a clear identifier, allowing users to easily distinguish LXCs configured with Tailscale for improved organization, management, and workflow integration. ### 📝 Detailed description This feature enhances the Tailscale installation script by introducing functionality to automatically assign a `tailscale` tag to the LXC container after the script successfully completes its execution. The tag acts as a label to identify the container as configured for Tailscale, improving ease of management and organization for users running multiple LXCs within their Proxmox environment. **Key Behavior:** - At the end of the Tailscale script, after installation and configuration steps are successfully completed, a `tailscale` tag should be added to the LXC container. - If the script fails at any point or does not complete, the tag should *not* be added, ensuring accuracy in tagging. - The feature can leverage Proxmox's built-in tagging mechanism (`pct set <LXC-ID> -tags tailscale`) to update the container's metadata. **Key Benefits:** 1. **Ease of Identification:** Users can instantly recognize which containers are configured to use Tailscale. This is particularly helpful in environments with numerous containers. 2. **Reduced User Intervention:** Automating the tagging process removes the need for manual tagging, reducing user workload and the potential for oversight. 3. **Improved Workflow:** Tags can be filtered, queried, or used in other scripts or systems managing Proxmox resources, simplifying complex workflows. 4. **Error Prevention:** Tagging only upon successful script execution ensures accuracy, preventing containers without complete Tailscale setups from being mislabeled. **Implementation Considerations:** - The script should verify if the Proxmox `pct` tool supports adding tags (available in modern versions of Proxmox VE). - Add error-handling to ensure that the tagging step does not interrupt or delay the overall script functionality. Logging should indicate whether the tag was successfully added. - Make sure the tagging step is only executed for valid LXC containers configured with Tailscale (e.g., skip tagging if the script is tested on unsupported distributions like Alpine). This feature aims to enhance overall usability and organization, making the script more user-friendly for complex Proxmox deployments. ### 💡 Why is this useful? Automatically assigning a `tailscale` tag to the LXC upon completion of the script can be useful for several reasons: 1. **Improved Organization:** In setups with multiple containers, it can be difficult to track which ones have specific configurations or services applied. A `tailscale` tag acts as a quick identifier, saving time and reducing confusion when managing multiple LXCs. 2. **Simplified Management:** Tags enable easier filtering or grouping of LXCs in tools or interfaces where that is supported. For example, if you're managing your containers via the Proxmox Web UI or API, it becomes much easier to search or sort for containers with specific roles. 3. **Reduced Human Error:** Adding the tag manually requires users to remember to do so after running the script, which is prone to oversight. Automating this removes an extra step for the user and ensures consistency. 4. **Easier Debugging:** If an issue arises later, identifying all Tailscale-configured containers quickly can narrow down the scope of troubleshooting. The tag provides a clear indication that the container is associated with Tailscale setup. 5. **Improved Workflow for Advanced Users:** Users scripting or automating their Proxmox LXC workflows could integrate the tagging mechanism into additional scripts or processes—like backups or updates—without adding redundant steps to check Tailscale's setup manually. Overall, adding the tag aligns with good systems management practices by promoting clarity, automation, and ease of use. It’s a small but meaningful quality-of-life improvement for administrators and users of the script.
saavagebueno added the enhancement label 2025-11-20 04:50:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?